ext4: avoid potential extra brelse in setup_new_flex_group_blocks()
authorVasily Averin <vvs@virtuozzo.com>
Sat, 3 Nov 2018 20:13:17 +0000 (16:13 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 3 Nov 2018 20:13:17 +0000 (16:13 -0400)
commit9e4028935cca3f9ef9b6a90df9da6f1f94853536
treecb4971051d8b712482e1deb64212b5611d5471e6
parent33458eaba4dfe778a426df6a19b7aad2ff9f7eec
ext4: avoid potential extra brelse in setup_new_flex_group_blocks()

Currently bh is set to NULL only during first iteration of for cycle,
then this pointer is not cleared after end of using.
Therefore rollback after errors can lead to extra brelse(bh) call,
decrements bh counter and later trigger an unexpected warning in __brelse()

Patch moves brelse() calls in body of cycle to exclude requirement of
brelse() call in rollback.

Fixes: 33afdcc5402d ("ext4: add a function which sets up group blocks ...")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org # 3.3+
fs/ext4/resize.c