drm/amd/powerplay: Zero initialize current_rpm in vega20_get_fan_speed_percent
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 4 Jul 2019 05:52:18 +0000 (22:52 -0700)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 8 Jul 2019 18:56:18 +0000 (13:56 -0500)
commit985863d00a8feb597a38df38f8fc2f70e980156f
treecd50474e13c8fe5f0b245f8b66790ed6cca487f0
parent68c3bd95018130d1cb34e77f6ba283b19cbb61ea
drm/amd/powerplay: Zero initialize current_rpm in vega20_get_fan_speed_percent

clang warns (trimmed for brevity):

drivers/gpu/drm/amd/amdgpu/../powerplay/vega20_ppt.c:3023:8: warning:
variable 'current_rpm' is used uninitialized whenever '?:' condition is
false [-Wsometimes-uninitialized]
        ret = smu_get_current_rpm(smu, &current_rpm);
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

smu_get_current_rpm expands to a ternary operator conditional on
smu->funcs->get_current_rpm being not NULL. When this is false,
current_rpm will be uninitialized. Zero initialize current_rpm to
avoid using random stack values if that ever happens.

Fixes: ee0db82027ee ("drm/amd/powerplay: move PPTable_t uses into asic level")
Link: https://github.com/ClangBuiltLinux/linux/issues/588
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/vega20_ppt.c