regulator: da9062: Use struct_size() in devm_kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Sat, 23 Feb 2019 01:54:51 +0000 (19:54 -0600)
committerMark Brown <broonie@kernel.org>
Tue, 26 Feb 2019 11:49:19 +0000 (11:49 +0000)
commit97b047e72bd6e63f2b6021b765b2afdf6b23c50c
tree45927915d660ab31fc7fe66d63635c56f1314d9a
parent1ec9c179c07ab6b17dd482033e0216409d46fc57
regulator: da9062: Use struct_size() in devm_kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

size = sizeof(struct foo) + count * sizeof(struct boo);
instance = alloc(size, GFP_KERNEL)

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = alloc(struct_size(instance, entry, count), GFP_KERNEL)

Notice that, in this case, variable size is not necessary, hence it is
removed.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/da9062-regulator.c