watchdog: Respect watchdog cpumask on CPU hotplug
authorThomas Gleixner <tglx@linutronix.de>
Tue, 26 Mar 2019 21:51:02 +0000 (22:51 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 28 Mar 2019 12:32:01 +0000 (13:32 +0100)
commit7dd47617114921fdd8c095509e5e7b4373cc44a1
tree0a3fbd526965725d856df783250e62bbc1f6fa31
parent056d28d135bca0b1d0908990338e00e9dadaf057
watchdog: Respect watchdog cpumask on CPU hotplug

The rework of the watchdog core to use cpu_stop_work broke the watchdog
cpumask on CPU hotplug.

The watchdog_enable/disable() functions are now called unconditionally from
the hotplug callback, i.e. even on CPUs which are not in the watchdog
cpumask. As a consequence the watchdog can become unstoppable.

Only invoke them when the plugged CPU is in the watchdog cpumask.

Fixes: 9cf57731b63e ("watchdog/softlockup: Replace "watchdog/%u" threads with cpu_stop_work")
Reported-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1903262245490.1789@nanos.tec.linutronix.de
kernel/watchdog.c