sctp: check policy more carefully when getting pr status
authorXin Long <lucien.xin@gmail.com>
Mon, 29 Oct 2018 15:13:11 +0000 (23:13 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 30 Oct 2018 03:50:41 +0000 (20:50 -0700)
commit713358369382cebf92f6e98ce2005f94e7344931
tree6c8de4c6dba99bc5b78eefa807eb047cff2505ff
parentdf132eff463873e14e019a07f387b4d577d6d1f9
sctp: check policy more carefully when getting pr status

When getting pr_assocstatus and pr_streamstatus by sctp_getsockopt,
it doesn't correctly process the case when policy is set with
SCTP_PR_SCTP_ALL | SCTP_PR_SCTP_MASK. It even causes a
slab-out-of-bounds in sctp_getsockopt_pr_streamstatus().

This patch fixes it by return -EINVAL for this case.

Fixes: 0ac1077e3a54 ("sctp: get pr_assoc and pr_stream all status with SCTP_PR_SCTP_ALL")
Reported-by: syzbot+5da0d0a72a9e7d791748@syzkaller.appspotmail.com
Suggested-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/socket.c