spi: spidev: Fix OF tree warning logic
authorTrent Piepho <tpiepho@impinj.com>
Thu, 20 Sep 2018 19:18:34 +0000 (19:18 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 10 Oct 2018 12:46:54 +0000 (13:46 +0100)
commit605b3bec73cbd74b4ac937b580cd0b47d1300484
tree0779d01514d4268bb580f3eca5666cde20205eb4
parent5039563e7c25eccd7fec1de6706011009d1c5665
spi: spidev: Fix OF tree warning logic

spidev will make a big fuss if a device tree node binds a device by
using "spidev" as the node's compatible property.

However, the logic for this isn't looking for "spidev" in the
compatible, but rather checking that the device is NOT compatible with
spidev's list of devices.

This causes a false positive if a device not named "rohm,dh2228fv", etc.
binds to spidev, even if a means other than putting "spidev" in the
device tree was used.  E.g., the sysfs driver_override attribute.

Signed-off-by: Trent Piepho <tpiepho@impinj.com>
Reviewed-by: Jan Kundrát <jan.kundrat@cesnet.cz>
Tested-by: Jan Kundrát <jan.kundrat@cesnet.cz>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spidev.c