drm/vmwgfx: Fix up user_dmabuf refcounting
authorThomas Hellstrom <thellstrom@vmware.com>
Mon, 14 Sep 2015 08:13:11 +0000 (01:13 -0700)
committerThomas Hellstrom <thellstrom@vmware.com>
Mon, 14 Sep 2015 08:13:11 +0000 (01:13 -0700)
commit54c12bc374408faddbff75dbf1a6167c19af39c4
tree15f78c5ccbc97a04aab1b0612c59626e0608d66f
parent9fbcc7c007ea200357e2453c6b2b153646fbc165
drm/vmwgfx: Fix up user_dmabuf refcounting

If user space calls unreference on a user_dmabuf it will typically
kill the struct ttm_base_object member which is responsible for the
user-space visibility. However the dmabuf part may still be alive and
refcounted. In some situations, like for shared guest-backed surface
referencing/opening, the driver may try to reference the
struct ttm_base_object member again, causing an immediate kernel warning
and a later kernel NULL pointer dereference.

Fix this by always maintaining a reference on the struct
ttm_base_object member, in situations where it might subsequently be
referenced.

Cc: <stable@vger.kernel.org>
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c
drivers/gpu/drm/vmwgfx/vmwgfx_resource.c
drivers/gpu/drm/vmwgfx/vmwgfx_shader.c
drivers/gpu/drm/vmwgfx/vmwgfx_surface.c