kbuild: initialize CLANG_FLAGS correctly in the top Makefile
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Mon, 29 Jul 2019 09:15:17 +0000 (18:15 +0900)
committerMasahiro Yamada <yamada.masahiro@socionext.com>
Tue, 30 Jul 2019 16:00:58 +0000 (01:00 +0900)
commit5241ab4cf42d3a93b933b55d3d53f43049081fa1
tree2af50c0e6f72de941b0dc130d7342b2556555750
parent622445541b751ce70a952b8486ce4512a792c0a2
kbuild: initialize CLANG_FLAGS correctly in the top Makefile

CLANG_FLAGS is initialized by the following line:

  CLANG_FLAGS     := --target=$(notdir $(CROSS_COMPILE:%-=%))

..., which is run only when CROSS_COMPILE is set.

Some build targets (bindeb-pkg etc.) recurse to the top Makefile.

When you build the kernel with Clang but without CROSS_COMPILE,
the same compiler flags such as -no-integrated-as are accumulated
into CLANG_FLAGS.

If you run 'make CC=clang' and then 'make CC=clang bindeb-pkg',
Kbuild will recompile everything needlessly due to the build command
change.

Fix this by correctly initializing CLANG_FLAGS.

Fixes: 238bcbc4e07f ("kbuild: consolidate Clang compiler flags")
Cc: <stable@vger.kernel.org> # v5.0+
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Makefile