NFS: Fix use-after-free in nfs4_init_client()
authorAnna Schumaker <Anna.Schumaker@Netapp.com>
Wed, 2 Jun 2021 18:31:20 +0000 (14:31 -0400)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Thu, 3 Jun 2021 14:14:42 +0000 (10:14 -0400)
commit476bdb04c501fc64bf3b8464ffddefc8dbe01577
tree76a5b824b2de241abfe6ba71e3989837d0e246a8
parent0b4f132b15f988831dfca8f96af272e437eacf05
NFS: Fix use-after-free in nfs4_init_client()

KASAN reports a use-after-free when attempting to mount two different
exports through two different NICs that belong to the same server.

Olga was able to hit this with kernels starting somewhere between 5.7
and 5.10, but I traced the patch that introduced the clear_bit() call to
4.13. So something must have changed in the refcounting of the clp
pointer to make this call to nfs_put_client() the very last one.

Fixes: 8dcbec6d20 ("NFSv41: Handle EXCHID4_FLAG_CONFIRMED_R during NFSv4.1 migration")
Cc: stable@vger.kernel.org # 4.13+
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/nfs4client.c