media: videobuf-dma-sg: Fix dma_{sync,unmap}_sg() calls
authorRobin Murphy <robin.murphy@arm.com>
Mon, 30 Apr 2018 16:56:28 +0000 (12:56 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 9 May 2018 20:25:12 +0000 (16:25 -0400)
commit4573027b67cbf51a1b4363e0e75437491c5279d9
treeaed863c8a4b66d0ac32fcbe0693cd942072b99e2
parentc591358446a298aab69cc7b405fc0db4f6da2d53
media: videobuf-dma-sg: Fix dma_{sync,unmap}_sg() calls

This reverts commit fc7f8fd42c2b934ac348995e0c530c917fc277d5.

Whilst the rationale for the above commit was in general correct, i.e.
that users *consuming* the DMA addresses should rely on sglen rather
than num_pages, it has always been the case that the DMA API itself
still requires that dma_{sync,unmap}_sg() are called with the original
number of entries as passed to dma_map_sg(), not the number of mapped
entries it returned. Thus the particular changes made in that patch
were erroneous.

At worst this might lead to data loss at the tail end of mapped buffers
on non-coherent hardware, while at best it's an example of incorrect
DMA API usage which has proven to mislead readers.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/v4l2-core/videobuf-dma-sg.c