ARM: 8813/1: Make aligned 2-byte getuser()/putuser() atomic on ARMv6+
authorVincent Whitchurch <vincent.whitchurch@axis.com>
Fri, 9 Nov 2018 09:12:30 +0000 (10:12 +0100)
committerRussell King <rmk+kernel@armlinux.org.uk>
Mon, 12 Nov 2018 10:52:04 +0000 (10:52 +0000)
commit344eb5539abf3e0b6ce22568c03e86450073e097
tree7ed1b8d9e68977e903e738c518e64cecb5936b8a
parentf441882a5229ffaef61a47bccd4518f7e2749cbc
ARM: 8813/1: Make aligned 2-byte getuser()/putuser() atomic on ARMv6+

getuser() and putuser() (and there underscored variants) use two
strb[t]/ldrb[t] instructions when they are asked to get/put 16-bits.
This means that the read/write is not atomic even when performed to a
16-bit-aligned address.

This leads to problems with vhost: vhost uses __getuser() to read the
vring's 16-bit avail.index field, and if it happens to observe a partial
update of the index, wrong descriptors will be used which will lead to a
breakdown of the virtio communication.  A similar problem exists for
__putuser() which is used to write to the vring's used.index field.

The reason these functions use strb[t]/ldrb[t] is because strht/ldrht
instructions did not exist until ARMv6T2/ARMv7.  So we should be easily
able to fix this on ARMv7.  Also, since all ARMv6 processors also don't
actually use the unprivileged instructions anymore for uaccess (since
CONFIG_CPU_USE_DOMAINS is not used) we can easily fix them too.

Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
arch/arm/include/asm/uaccess.h
arch/arm/lib/getuser.S
arch/arm/lib/putuser.S