MIPS: OCTEON: make get_system_type() thread-safe
authorAaro Koskinen <aaro.koskinen@nsn.com>
Tue, 22 Jul 2014 11:51:08 +0000 (14:51 +0300)
committerRalf Baechle <ralf@linux-mips.org>
Tue, 26 Aug 2014 00:18:57 +0000 (02:18 +0200)
commit33d9a530d4a87c5d645cfc82f23108ca8d89aa78
treec526f119bb038cb920999356635f7fbd085c62e3
parent56d2960958f81db9cfd488e530d2206edede5f8f
MIPS: OCTEON: make get_system_type() thread-safe

get_system_type() is not thread-safe on OCTEON. It uses static data,
also more dangerous issue is that it's calling cvmx_fuse_read_byte()
every time without any synchronization. Currently it's possible to get
processes stuck looping forever in kernel simply by launching multiple
readers of /proc/cpuinfo:

(while true; do cat /proc/cpuinfo > /dev/null; done) &
(while true; do cat /proc/cpuinfo > /dev/null; done) &
...

Fix by initializing the system type string only once during the early
boot.

Signed-off-by: Aaro Koskinen <aaro.koskinen@nsn.com>
Cc: stable@vger.kernel.org
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
Patchwork: http://patchwork.linux-mips.org/patch/7437/
Signed-off-by: James Hogan <james.hogan@imgtec.com>
arch/mips/cavium-octeon/setup.c