selftests/powerpc: Fix compilation issue due to asm label
authorNaveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Wed, 31 Oct 2018 17:18:13 +0000 (22:48 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 31 Oct 2018 23:06:03 +0000 (10:06 +1100)
commit1936f094e164cc13ebf17aba1d6b34e033e64188
tree2a4d2b0dcd3bde1dc35b6f0a263a93c0d37f2522
parent69f8117f17b332a68cd8f4bf8c2d0d3d5b84efc5
selftests/powerpc: Fix compilation issue due to asm label

We are using 'dscr_insn' as a label in inline asm to identify if a
SIGILL was generated by the mtspr instruction at that point. However,
with inline assembly, the compiler is still free to duplicate the asm
statement for optimization purposes, which results in the label being
defined twice with the error:
/tmp/ccerQCql.s:874: Error: symbol `dscr_insn' is already defined

With different compiler versions, we may also see:
/tmp/ccJzLDlN.o:(.toc+0x0): undefined reference to `dscr_insn'

Remove the use of the label in the inline assembly. Instead, just look
for the offending instruction in the signal handler.

Fixes: d2bf793237b3 ("selftests/powerpc: Add test to verify rfi flush across a system call")
Reported-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Tested-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
tools/testing/selftests/powerpc/utils.c