drivers/perf: arm_pmu: Defer the setting of __oprofile_cpu_pmu
authorJulien Grall <julien.grall@arm.com>
Tue, 31 May 2016 11:41:22 +0000 (12:41 +0100)
committerWill Deacon <will.deacon@arm.com>
Fri, 3 Jun 2016 09:16:21 +0000 (10:16 +0100)
commit0f254c7671e851243412bce6c2e618732831d0f8
tree89765603a9ca1a9f88830b09d6244f693398aea8
parent121323ae668e456d0ed328f5b77c22bf5dd8e4de
drivers/perf: arm_pmu: Defer the setting of __oprofile_cpu_pmu

The global variable __oprofile_cpu_pmu is set before the PMU is fully
initialized. If an error occurs before the end of the initialization,
the PMU will be freed and the variable will contain an invalid pointer.

This will result in a kernel crash when perf will be used.

Fix it by moving the setting of __oprofile_cpu_pmu when the PMU is fully
initialized (i.e when it is no longer possible to fail).

Cc: <stable@vger.kernel.org>
Signed-off-by: Julien Grall <julien.grall@arm.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
drivers/perf/arm_pmu.c