perf tests: Show refcounting broken expectations in thread-mg-share test
authorArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 11 May 2015 19:30:20 +0000 (16:30 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 12 May 2015 12:59:51 +0000 (09:59 -0300)
commit8f1960138baf8a6c139917ecbc032e7916d109ef
tree24f1fad1b9eca4ab65a00ac9129b635caccedd79
parent021162cf02fcfa80cbae5f3b7304e9cb392962eb
perf tests: Show refcounting broken expectations in thread-mg-share test

To help understand the failure.

  [acme@zoo linux]$ perf test -v 30
  30: Test thread mg sharing                                 :
  --- start ---
  test child forked, pid 12275
  FAILED tests/thread-mg-share.c:68 wrong refcnt (4 != 3)
  test child finished with -1
  ---- end ----
  Test thread mg sharing: FAILED!
  [acme@zoo linux]$

This is under investigation, the thread__delete() calls were replaced
with thread__put(), and those cause mismatches because now we need to be
more judicious with the thread lifetime management.

I.e. previously the thread__delete() would drop the map_group refcount,
but now since thread__put doesn't call thread__delete() necessarily.
because we have other refcount holders, the map_group refcount will not
be as we expected when this test was implemented.

Will be fixed soon...

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-9y8e3f7ukzco5loxvnlitpfq@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/tests.h
tools/perf/tests/thread-mg-share.c