libceph: avoid unregistering osd request when not registered
authorSage Weil <sage@inktank.com>
Wed, 16 May 2012 20:16:38 +0000 (15:16 -0500)
committerSage Weil <sage@inktank.com>
Sat, 19 May 2012 00:36:00 +0000 (17:36 -0700)
commit35f9f8a09e1e88e31bd34a1e645ca0e5f070dd5c
treec7bc4a1dba445ea2e250decbf9b88282ee37cb3f
parent3da54776e2c0385c32d143fd497a7f40a88e29dd
libceph: avoid unregistering osd request when not registered

There is a race between two __unregister_request() callers: the
reply path and the ceph_osdc_wait_request().  If we get a reply
*and* the timeout expires at roughly the same time, both callers
will try to unregister the request, and the second one will do bad
things.

Simply check if the request is still already unregistered; if so,
return immediately and do nothing.

Fixes http://tracker.newdream.net/issues/2420

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Alex Elder <elder@inktank.com>
net/ceph/osd_client.c