mm: move_ptes -- Set soft dirty bit depending on pte type
authorCyrill Gorcunov <gorcunov@gmail.com>
Tue, 27 Aug 2013 08:37:18 +0000 (12:37 +0400)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 27 Aug 2013 16:36:17 +0000 (09:36 -0700)
commit6dec97dc92946eb479e6ebb54a61f8226cceefec
tree7065d6d5f27b19ce4773460d50c1502610848f64
parent9b506833210fdaea2cd00e39368805e28f49492d
mm: move_ptes -- Set soft dirty bit depending on pte type

Dave reported corrupted swap entries

 | [ 4588.541886] swap_free: Unused swap offset entry 00002d15
 | [ 4588.541952] BUG: Bad page map in process trinity-kid12  pte:005a2a80 pmd:22c01f067

and Hugh pointed that in move_ptes _PAGE_SOFT_DIRTY bit set regardless
the type of entry pte consists of.  The trick here is that when we carry
soft dirty status in swap entries we are to use _PAGE_SWP_SOFT_DIRTY
instead, because this is the only place in pte which can be used for own
needs without intersecting with bits owned by swap entry type/offset.

Reported-and-tested-by: Dave Jones <davej@redhat.com>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Pavel Emelyanov <xemul@parallels.com>
Analyzed-by: Hugh Dickins <hughd@google.com>
Cc: Hillf Danton <dhillf@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/mremap.c