workqueue: fix bugs in wq_update_unbound_numa() failure path
authorDaeseok Youn <daeseok.youn@gmail.com>
Wed, 16 Apr 2014 05:32:29 +0000 (14:32 +0900)
committerTejun Heo <tj@kernel.org>
Wed, 16 Apr 2014 17:27:57 +0000 (13:27 -0400)
commit77f300b198f93328c26191b52655ce1b62e202cf
tree9240e7cdcdf9f2211b52d789365c2bf1d00c8011
parentc9eaa447e77efe77b7fa4c953bd62de8297fd6c5
workqueue: fix bugs in wq_update_unbound_numa() failure path

wq_update_unbound_numa() failure path has the following two bugs.

- alloc_unbound_pwq() is called without holding wq->mutex; however, if
  the allocation fails, it jumps to out_unlock which tries to unlock
  wq->mutex.

- The function should switch to dfl_pwq on failure but didn't do so
  after alloc_unbound_pwq() failure.

Fix it by regrabbing wq->mutex and jumping to use_dfl_pwq on
alloc_unbound_pwq() failure.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Acked-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org
Fixes: 4c16bd327c74 ("workqueue: implement NUMA affinity for unbound workqueues")
kernel/workqueue.c