watchdog: Rename confusing state variable
authorFrederic Weisbecker <fweisbec@gmail.com>
Sun, 19 May 2013 18:45:15 +0000 (20:45 +0200)
committerFrederic Weisbecker <fweisbec@gmail.com>
Thu, 20 Jun 2013 13:41:18 +0000 (15:41 +0200)
commit3c00ea82c724fab0b98f15428a804cb45eb9ad38
tree3e380db50cf9bc5d2962c25cc80707bfd9fc834c
parentb8900bc0217fac8e68085997bee2f05e6db931a2
watchdog: Rename confusing state variable

We have two very conflicting state variable names in the
watchdog:

* watchdog_enabled: This one reflects the user interface. It's
set to 1 by default and can be overriden with boot options
or sysctl/procfs interface.

* watchdog_disabled: This is the internal toggle state that
tells if watchdog threads, timers and NMI events are currently
running or not. This state mostly depends on the user settings.
It's a convenient state latch.

Now we really need to find clearer names because those
are just too confusing to encourage deep review.

watchdog_enabled now becomes watchdog_user_enabled to reflect
its purpose as an interface.

watchdog_disabled becomes watchdog_running to suggest its
role as a pure internal state.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Cc: Anish Singh <anish198519851985@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Li Zhong <zhong@linux.vnet.ibm.com>
Cc: Don Zickus <dzickus@redhat.com>
include/linux/nmi.h
kernel/sysctl.c
kernel/watchdog.c