sched/fair: Cure calc_cfs_shares() vs. reweight_entity()
authorPeter Zijlstra <peterz@infradead.org>
Thu, 11 May 2017 16:16:06 +0000 (18:16 +0200)
committerIngo Molnar <mingo@kernel.org>
Fri, 29 Sep 2017 17:35:11 +0000 (19:35 +0200)
commit3d4b60d3e3dde6ea24e439000eb3b71078da81f1
tree98b441ccd2236ce2a8efebeb8bb961f2d45730ec
parentcef27403cbe98ebda0a32d43128dd60c309eb966
sched/fair: Cure calc_cfs_shares() vs. reweight_entity()

Vincent reported that when running in a cgroup, his root
cfs_rq->avg.load_avg dropped to 0 on task idle.

This is because reweight_entity() will now immediately propagate the
weight change of the group entity to its cfs_rq, and as it happens,
our approxmation (5) for calc_cfs_shares() results in 0 when the group
is idle.

Avoid this by using the correct (3) as a lower bound on (5). This way
the empty cgroup will slowly decay instead of instantly drop to 0.

Reported-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/fair.c