module: Call module notifier on failure after complete_formation()
authorSteven Rostedt <rostedt@goodmis.org>
Fri, 8 May 2015 17:36:23 +0000 (03:06 +0930)
committerRusty Russell <rusty@rustcorp.com.au>
Fri, 8 May 2015 17:59:24 +0000 (03:29 +0930)
commit37815bf866ab6722a47550f8d25ad3f1a16a680c
treefdb27ea2c0267dea6a4ce5cfcaad8c32db47a15e
parent3e0283a53f7d2f2dae7bc4aa7f3104cb5988018f
module: Call module notifier on failure after complete_formation()

The module notifier call chain for MODULE_STATE_COMING was moved up before
the parsing of args, into the complete_formation() call. But if the module failed
to load after that, the notifier call chain for MODULE_STATE_GOING was
never called and that prevented the users of those call chains from
cleaning up anything that was allocated.

Link: http://lkml.kernel.org/r/554C52B9.9060700@gmail.com
Reported-by: Pontus Fuchs <pontus.fuchs@gmail.com>
Fixes: 4982223e51e8 "module: set nx before marking module MODULE_STATE_COMING"
Cc: stable@vger.kernel.org # 3.16+
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
kernel/module.c