kallsyms: Refactor kallsyms_show_value() to take cred
authorKees Cook <keescook@chromium.org>
Thu, 2 Jul 2020 18:49:23 +0000 (11:49 -0700)
committerKees Cook <keescook@chromium.org>
Wed, 8 Jul 2020 22:59:57 +0000 (15:59 -0700)
commit160251842cd35a75edfb0a1d76afa3eb674ff40a
treea1ce82f3b8d23a325c151bd998b815af9574617c
parent48778464bb7d346b47157d21ffde2af6b2d39110
kallsyms: Refactor kallsyms_show_value() to take cred

In order to perform future tests against the cred saved during open(),
switch kallsyms_show_value() to operate on a cred, and have all current
callers pass current_cred(). This makes it very obvious where callers
are checking the wrong credential in their "read" contexts. These will
be fixed in the coming patches.

Additionally switch return value to bool, since it is always used as a
direct permission check, not a 0-on-success, negative-on-error style
function return.

Cc: stable@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
include/linux/filter.h
include/linux/kallsyms.h
kernel/kallsyms.c
kernel/kprobes.c
kernel/module.c