net/mlx5: Fix race for multiple RoCE enable
authorDaniel Jurgens <danielj@mellanox.com>
Thu, 4 Jan 2018 15:25:31 +0000 (17:25 +0200)
committerJason Gunthorpe <jgg@mellanox.com>
Mon, 8 Jan 2018 18:42:20 +0000 (11:42 -0700)
commit734dc065fc41f6143ff88225aa5d335cb1e0f6aa
tree4c6bd43972f743d469b5c9d1f875cc9bd6ca2a26
parent776a3906b692963586ee9952e64ed87fb4b401c6
net/mlx5: Fix race for multiple RoCE enable

There are two potential problems with the existing implementation.

1. Enable and disable can race after the atomic operations.
2. If a command fails the refcount is left in an inconsistent state.

Introduce a lock and perform error checking.

Fixes: a6f7d2aff623 ("net/mlx5: Add support for multiple RoCE enable")
Signed-off-by: Daniel Jurgens <danielj@mellanox.com>
Reviewed-by: Parav Pandit <parav@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/vport.c
include/linux/mlx5/driver.h