vfs: simple_set_mnt() should return void
authorSukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Wed, 4 Mar 2009 20:06:34 +0000 (12:06 -0800)
committerAl Viro <viro@zeniv.linux.org.uk>
Fri, 27 Mar 2009 18:44:03 +0000 (14:44 -0400)
commita3ec947c85ec339884b30ef6a08133e9311fdae1
treec3cc5859a6b6d8986547405b6c5bd11bc8916114
parent585d3bc06f4ca57f975a5a1f698f65a45ea66225
vfs: simple_set_mnt() should return void

simple_set_mnt() is defined as returning 'int' but always returns 0.
Callers assume simple_set_mnt() never fails and don't properly cleanup if
it were to _ever_ fail.  For instance, get_sb_single() and get_sb_nodev()
should:

        up_write(sb->s_unmount);
        deactivate_super(sb);

if simple_set_mnt() fails.

Since simple_set_mnt() never fails, would be cleaner if it did not
return anything.

[akpm@linux-foundation.org: fix build]
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
drivers/mtd/mtdsuper.c
fs/9p/vfs_super.c
fs/cifs/cifsfs.c
fs/devpts/inode.c
fs/libfs.c
fs/namespace.c
fs/proc/root.c
fs/super.c
fs/ubifs/super.c
include/linux/fs.h
kernel/cgroup.c