fix a leak in replace_fd() users
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 16 Oct 2012 17:30:07 +0000 (13:30 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 16 Oct 2012 17:36:50 +0000 (13:36 -0400)
commit45525b26a46cd593cb72070304c4cd7c8391bd37
tree9064f045ef433e4d74d281daa995ee3c082e806e
parentdd8e8c4a2c902d8350b702e7bc7c2799e5e7e331
fix a leak in replace_fd() users

replace_fd() began with "eats a reference, tries to insert into
descriptor table" semantics; at some point I'd switched it to
much saner current behaviour ("try to insert into descriptor
table, grabbing a new reference if inserted; caller should do
fput() in any case"), but forgot to update the callers.
Mea culpa...

[Spotted by Pavel Roskin, who has really weird system with pipe-fed
coredumps as part of what he considers a normal boot ;-)]

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/coredump.c
security/selinux/hooks.c