arm64: Fix deadlock scenario with smp_send_stop()
authorArun KS <arunks.linux@gmail.com>
Wed, 7 May 2014 01:41:23 +0000 (02:41 +0100)
committerCatalin Marinas <catalin.marinas@arm.com>
Fri, 16 May 2014 17:03:33 +0000 (18:03 +0100)
commitb9acc49ee9464f8f8232a790045d057eb158e869
treee99259f1dfa0e90effebcf3f41da03775bf615ef
parent90f51a09ef83703b6c2e0434e0384b61b59699d3
arm64: Fix deadlock scenario with smp_send_stop()

If one process calls sys_reboot and that process then stops other
CPUs while those CPUs are within a spin_lock() region we can
potentially encounter a deadlock scenario like below.

CPU 0                   CPU 1
-----                   -----
                        spin_lock(my_lock)
smp_send_stop()
 <send IPI>             handle_IPI()
                         disable_preemption/irqs
                          while(1);
 <PREEMPT>
spin_lock(my_lock) <--- Waits forever

We shouldn't attempt to run any other tasks after we send a stop
IPI to a CPU so disable preemption so that this task runs to
completion. We use local_irq_disable() here for cross-arch
consistency with x86.

Based-on-work-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Arun KS <getarunks@gmail.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/kernel/process.c