drm/i915: Leave the aliasing-ppgtt size alone
[linux-2.6-block.git] / drivers / gpu / drm / i915 / i915_gem_gtt.c
index 3148d5946b63c62ae5c81e324cf5992f8bf089f1..6239a9adbf14e4cf0e1973039d58303af1737101 100644 (file)
@@ -2609,8 +2609,6 @@ static int init_aliasing_ppgtt(struct i915_ggtt *ggtt)
        GEM_BUG_ON(ggtt->vm.vma_ops.unbind_vma != ggtt_unbind_vma);
        ggtt->vm.vma_ops.unbind_vma = aliasing_gtt_unbind_vma;
 
-       ppgtt->vm.total = ggtt->vm.total;
-
        return 0;
 
 err_ppgtt:
@@ -2661,7 +2659,8 @@ static void ggtt_release_guc_top(struct i915_ggtt *ggtt)
 static void cleanup_init_ggtt(struct i915_ggtt *ggtt)
 {
        ggtt_release_guc_top(ggtt);
-       drm_mm_remove_node(&ggtt->error_capture);
+       if (drm_mm_node_allocated(&ggtt->error_capture))
+               drm_mm_remove_node(&ggtt->error_capture);
 }
 
 static int init_ggtt(struct i915_ggtt *ggtt)
@@ -2692,13 +2691,15 @@ static int init_ggtt(struct i915_ggtt *ggtt)
        if (ret)
                return ret;
 
-       /* Reserve a mappable slot for our lockless error capture */
-       ret = drm_mm_insert_node_in_range(&ggtt->vm.mm, &ggtt->error_capture,
-                                         PAGE_SIZE, 0, I915_COLOR_UNEVICTABLE,
-                                         0, ggtt->mappable_end,
-                                         DRM_MM_INSERT_LOW);
-       if (ret)
-               return ret;
+       if (ggtt->mappable_end) {
+               /* Reserve a mappable slot for our lockless error capture */
+               ret = drm_mm_insert_node_in_range(&ggtt->vm.mm, &ggtt->error_capture,
+                                                 PAGE_SIZE, 0, I915_COLOR_UNEVICTABLE,
+                                                 0, ggtt->mappable_end,
+                                                 DRM_MM_INSERT_LOW);
+               if (ret)
+                       return ret;
+       }
 
        /*
         * The upper portion of the GuC address space has a sizeable hole
@@ -2744,59 +2745,6 @@ int i915_init_ggtt(struct drm_i915_private *i915)
        return 0;
 }
 
-void i915_gem_cleanup_memory_regions(struct drm_i915_private *i915)
-{
-       int i;
-
-       for (i = 0; i < INTEL_REGION_UNKNOWN; i++) {
-               struct intel_memory_region *region = i915->mm.regions[i];
-
-               if (region)
-                       intel_memory_region_put(region);
-       }
-}
-
-int i915_gem_init_memory_regions(struct drm_i915_private *i915)
-{
-       int err, i;
-
-       for (i = 0; i < INTEL_REGION_UNKNOWN; i++) {
-               struct intel_memory_region *mem = ERR_PTR(-ENODEV);
-               u32 type;
-
-               if (!HAS_REGION(i915, BIT(i)))
-                       continue;
-
-               type = MEMORY_TYPE_FROM_REGION(intel_region_map[i]);
-               switch (type) {
-               case INTEL_MEMORY_SYSTEM:
-                       mem = i915_gem_shmem_setup(i915);
-                       break;
-               case INTEL_MEMORY_STOLEN:
-                       mem = i915_gem_stolen_setup(i915);
-                       break;
-               }
-
-               if (IS_ERR(mem)) {
-                       err = PTR_ERR(mem);
-                       DRM_ERROR("Failed to setup region(%d) type=%d\n", err, type);
-                       goto out_cleanup;
-               }
-
-               mem->id = intel_region_map[i];
-               mem->type = type;
-               mem->instance = MEMORY_INSTANCE_FROM_REGION(intel_region_map[i]);
-
-               i915->mm.regions[i] = mem;
-       }
-
-       return 0;
-
-out_cleanup:
-       i915_gem_cleanup_memory_regions(i915);
-       return err;
-}
-
 static void ggtt_cleanup_hw(struct i915_ggtt *ggtt)
 {
        struct i915_vma *vma, *vn;
@@ -2823,7 +2771,9 @@ static void ggtt_cleanup_hw(struct i915_ggtt *ggtt)
        i915_address_space_fini(&ggtt->vm);
 
        arch_phys_wc_del(ggtt->mtrr);
-       io_mapping_fini(&ggtt->iomap);
+
+       if (ggtt->iomap.size)
+               io_mapping_fini(&ggtt->iomap);
 }
 
 /**
@@ -2834,8 +2784,6 @@ void i915_ggtt_driver_release(struct drm_i915_private *i915)
 {
        struct pagevec *pvec;
 
-       i915_gem_cleanup_memory_regions(i915);
-
        fini_aliasing_ppgtt(&i915->ggtt);
 
        ggtt_cleanup_hw(&i915->ggtt);
@@ -2922,35 +2870,51 @@ static int ggtt_probe_common(struct i915_ggtt *ggtt, u64 size)
        return 0;
 }
 
-static void tgl_setup_private_ppat(struct drm_i915_private *dev_priv)
+static void tgl_setup_private_ppat(struct intel_uncore *uncore)
 {
        /* TGL doesn't support LLC or AGE settings */
-       I915_WRITE(GEN12_PAT_INDEX(0), GEN8_PPAT_WB);
-       I915_WRITE(GEN12_PAT_INDEX(1), GEN8_PPAT_WC);
-       I915_WRITE(GEN12_PAT_INDEX(2), GEN8_PPAT_WT);
-       I915_WRITE(GEN12_PAT_INDEX(3), GEN8_PPAT_UC);
-       I915_WRITE(GEN12_PAT_INDEX(4), GEN8_PPAT_WB);
-       I915_WRITE(GEN12_PAT_INDEX(5), GEN8_PPAT_WB);
-       I915_WRITE(GEN12_PAT_INDEX(6), GEN8_PPAT_WB);
-       I915_WRITE(GEN12_PAT_INDEX(7), GEN8_PPAT_WB);
-}
-
-static void cnl_setup_private_ppat(struct drm_i915_private *dev_priv)
-{
-       I915_WRITE(GEN10_PAT_INDEX(0), GEN8_PPAT_WB | GEN8_PPAT_LLC);
-       I915_WRITE(GEN10_PAT_INDEX(1), GEN8_PPAT_WC | GEN8_PPAT_LLCELLC);
-       I915_WRITE(GEN10_PAT_INDEX(2), GEN8_PPAT_WT | GEN8_PPAT_LLCELLC);
-       I915_WRITE(GEN10_PAT_INDEX(3), GEN8_PPAT_UC);
-       I915_WRITE(GEN10_PAT_INDEX(4), GEN8_PPAT_WB | GEN8_PPAT_LLCELLC | GEN8_PPAT_AGE(0));
-       I915_WRITE(GEN10_PAT_INDEX(5), GEN8_PPAT_WB | GEN8_PPAT_LLCELLC | GEN8_PPAT_AGE(1));
-       I915_WRITE(GEN10_PAT_INDEX(6), GEN8_PPAT_WB | GEN8_PPAT_LLCELLC | GEN8_PPAT_AGE(2));
-       I915_WRITE(GEN10_PAT_INDEX(7), GEN8_PPAT_WB | GEN8_PPAT_LLCELLC | GEN8_PPAT_AGE(3));
+       intel_uncore_write(uncore, GEN12_PAT_INDEX(0), GEN8_PPAT_WB);
+       intel_uncore_write(uncore, GEN12_PAT_INDEX(1), GEN8_PPAT_WC);
+       intel_uncore_write(uncore, GEN12_PAT_INDEX(2), GEN8_PPAT_WT);
+       intel_uncore_write(uncore, GEN12_PAT_INDEX(3), GEN8_PPAT_UC);
+       intel_uncore_write(uncore, GEN12_PAT_INDEX(4), GEN8_PPAT_WB);
+       intel_uncore_write(uncore, GEN12_PAT_INDEX(5), GEN8_PPAT_WB);
+       intel_uncore_write(uncore, GEN12_PAT_INDEX(6), GEN8_PPAT_WB);
+       intel_uncore_write(uncore, GEN12_PAT_INDEX(7), GEN8_PPAT_WB);
+}
+
+static void cnl_setup_private_ppat(struct intel_uncore *uncore)
+{
+       intel_uncore_write(uncore,
+                          GEN10_PAT_INDEX(0),
+                          GEN8_PPAT_WB | GEN8_PPAT_LLC);
+       intel_uncore_write(uncore,
+                          GEN10_PAT_INDEX(1),
+                          GEN8_PPAT_WC | GEN8_PPAT_LLCELLC);
+       intel_uncore_write(uncore,
+                          GEN10_PAT_INDEX(2),
+                          GEN8_PPAT_WT | GEN8_PPAT_LLCELLC);
+       intel_uncore_write(uncore,
+                          GEN10_PAT_INDEX(3),
+                          GEN8_PPAT_UC);
+       intel_uncore_write(uncore,
+                          GEN10_PAT_INDEX(4),
+                          GEN8_PPAT_WB | GEN8_PPAT_LLCELLC | GEN8_PPAT_AGE(0));
+       intel_uncore_write(uncore,
+                          GEN10_PAT_INDEX(5),
+                          GEN8_PPAT_WB | GEN8_PPAT_LLCELLC | GEN8_PPAT_AGE(1));
+       intel_uncore_write(uncore,
+                          GEN10_PAT_INDEX(6),
+                          GEN8_PPAT_WB | GEN8_PPAT_LLCELLC | GEN8_PPAT_AGE(2));
+       intel_uncore_write(uncore,
+                          GEN10_PAT_INDEX(7),
+                          GEN8_PPAT_WB | GEN8_PPAT_LLCELLC | GEN8_PPAT_AGE(3));
 }
 
 /* The GGTT and PPGTT need a private PPAT setup in order to handle cacheability
  * bits. When using advanced contexts each context stores its own PAT, but
  * writing this data shouldn't be harmful even in those cases. */
-static void bdw_setup_private_ppat(struct drm_i915_private *dev_priv)
+static void bdw_setup_private_ppat(struct intel_uncore *uncore)
 {
        u64 pat;
 
@@ -2963,11 +2927,11 @@ static void bdw_setup_private_ppat(struct drm_i915_private *dev_priv)
              GEN8_PPAT(6, GEN8_PPAT_WB | GEN8_PPAT_LLCELLC | GEN8_PPAT_AGE(2)) |
              GEN8_PPAT(7, GEN8_PPAT_WB | GEN8_PPAT_LLCELLC | GEN8_PPAT_AGE(3));
 
-       I915_WRITE(GEN8_PRIVATE_PAT_LO, lower_32_bits(pat));
-       I915_WRITE(GEN8_PRIVATE_PAT_HI, upper_32_bits(pat));
+       intel_uncore_write(uncore, GEN8_PRIVATE_PAT_LO, lower_32_bits(pat));
+       intel_uncore_write(uncore, GEN8_PRIVATE_PAT_HI, upper_32_bits(pat));
 }
 
-static void chv_setup_private_ppat(struct drm_i915_private *dev_priv)
+static void chv_setup_private_ppat(struct intel_uncore *uncore)
 {
        u64 pat;
 
@@ -2999,8 +2963,8 @@ static void chv_setup_private_ppat(struct drm_i915_private *dev_priv)
              GEN8_PPAT(6, CHV_PPAT_SNOOP) |
              GEN8_PPAT(7, CHV_PPAT_SNOOP);
 
-       I915_WRITE(GEN8_PRIVATE_PAT_LO, lower_32_bits(pat));
-       I915_WRITE(GEN8_PRIVATE_PAT_HI, upper_32_bits(pat));
+       intel_uncore_write(uncore, GEN8_PRIVATE_PAT_LO, lower_32_bits(pat));
+       intel_uncore_write(uncore, GEN8_PRIVATE_PAT_HI, upper_32_bits(pat));
 }
 
 static void gen6_gmch_remove(struct i915_address_space *vm)
@@ -3011,18 +2975,26 @@ static void gen6_gmch_remove(struct i915_address_space *vm)
        cleanup_scratch_page(vm);
 }
 
-static void setup_private_pat(struct drm_i915_private *dev_priv)
+static void setup_private_pat(struct intel_uncore *uncore)
 {
-       GEM_BUG_ON(INTEL_GEN(dev_priv) < 8);
+       struct drm_i915_private *i915 = uncore->i915;
 
-       if (INTEL_GEN(dev_priv) >= 12)
-               tgl_setup_private_ppat(dev_priv);
-       else if (INTEL_GEN(dev_priv) >= 10)
-               cnl_setup_private_ppat(dev_priv);
-       else if (IS_CHERRYVIEW(dev_priv) || IS_GEN9_LP(dev_priv))
-               chv_setup_private_ppat(dev_priv);
+       GEM_BUG_ON(INTEL_GEN(i915) < 8);
+
+       if (INTEL_GEN(i915) >= 12)
+               tgl_setup_private_ppat(uncore);
+       else if (INTEL_GEN(i915) >= 10)
+               cnl_setup_private_ppat(uncore);
+       else if (IS_CHERRYVIEW(i915) || IS_GEN9_LP(i915))
+               chv_setup_private_ppat(uncore);
        else
-               bdw_setup_private_ppat(dev_priv);
+               bdw_setup_private_ppat(uncore);
+}
+
+static struct resource pci_resource(struct pci_dev *pdev, int bar)
+{
+       return (struct resource)DEFINE_RES_MEM(pci_resource_start(pdev, bar),
+                                              pci_resource_len(pdev, bar));
 }
 
 static int gen8_gmch_probe(struct i915_ggtt *ggtt)
@@ -3034,10 +3006,10 @@ static int gen8_gmch_probe(struct i915_ggtt *ggtt)
        int err;
 
        /* TODO: We're not aware of mappable constraints on gen8 yet */
-       ggtt->gmadr =
-               (struct resource) DEFINE_RES_MEM(pci_resource_start(pdev, 2),
-                                                pci_resource_len(pdev, 2));
-       ggtt->mappable_end = resource_size(&ggtt->gmadr);
+       if (!IS_DGFX(dev_priv)) {
+               ggtt->gmadr = pci_resource(pdev, 2);
+               ggtt->mappable_end = resource_size(&ggtt->gmadr);
+       }
 
        err = pci_set_dma_mask(pdev, DMA_BIT_MASK(39));
        if (!err)
@@ -3078,7 +3050,7 @@ static int gen8_gmch_probe(struct i915_ggtt *ggtt)
 
        ggtt->vm.pte_encode = gen8_pte_encode;
 
-       setup_private_pat(dev_priv);
+       setup_private_pat(ggtt->vm.gt->uncore);
 
        return ggtt_probe_common(ggtt, size);
 }
@@ -3260,14 +3232,17 @@ static int ggtt_init_hw(struct i915_ggtt *ggtt)
        if (!HAS_LLC(i915) && !HAS_PPGTT(i915))
                ggtt->vm.mm.color_adjust = i915_ggtt_color_adjust;
 
-       if (!io_mapping_init_wc(&ggtt->iomap,
-                               ggtt->gmadr.start,
-                               ggtt->mappable_end)) {
-               ggtt->vm.cleanup(&ggtt->vm);
-               return -EIO;
-       }
+       if (ggtt->mappable_end) {
+               if (!io_mapping_init_wc(&ggtt->iomap,
+                                       ggtt->gmadr.start,
+                                       ggtt->mappable_end)) {
+                       ggtt->vm.cleanup(&ggtt->vm);
+                       return -EIO;
+               }
 
-       ggtt->mtrr = arch_phys_wc_add(ggtt->gmadr.start, ggtt->mappable_end);
+               ggtt->mtrr = arch_phys_wc_add(ggtt->gmadr.start,
+                                             ggtt->mappable_end);
+       }
 
        i915_ggtt_init_fences(ggtt);
 
@@ -3293,15 +3268,7 @@ int i915_ggtt_init_hw(struct drm_i915_private *dev_priv)
        if (ret)
                return ret;
 
-       ret = i915_gem_init_memory_regions(dev_priv);
-       if (ret)
-               goto out_gtt_cleanup;
-
        return 0;
-
-out_gtt_cleanup:
-       dev_priv->ggtt.vm.cleanup(&dev_priv->ggtt.vm);
-       return ret;
 }
 
 int i915_ggtt_enable_hw(struct drm_i915_private *dev_priv)
@@ -3382,10 +3349,12 @@ static void ggtt_restore_mappings(struct i915_ggtt *ggtt)
 
 void i915_gem_restore_gtt_mappings(struct drm_i915_private *i915)
 {
-       ggtt_restore_mappings(&i915->ggtt);
+       struct i915_ggtt *ggtt = &i915->ggtt;
+
+       ggtt_restore_mappings(ggtt);
 
        if (INTEL_GEN(i915) >= 8)
-               setup_private_pat(i915);
+               setup_private_pat(ggtt->vm.gt->uncore);
 }
 
 static struct scatterlist *