projects
/
fio.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
CPU burn engine fix
[fio.git]
/
fio.c
diff --git
a/fio.c
b/fio.c
index 94da6b48744ca7a5bc9fccb019e082c2fb01da30..841b59a5ae3111c588338b10ef9c2477d6f5740e 100644
(file)
--- a/
fio.c
+++ b/
fio.c
@@
-60,6
+60,8
@@
struct io_log *agg_io_log[2];
static inline void td_set_runstate(struct thread_data *td, int runstate)
{
static inline void td_set_runstate(struct thread_data *td, int runstate)
{
+ dprint(FD_PROCESS, "%d: runstate %d -> %d\n", td->pid, td->runstate,
+ runstate);
td->runstate = runstate;
}
td->runstate = runstate;
}
@@
-70,6
+72,7
@@
static void terminate_threads(int group_id)
for_each_td(td, i) {
if (group_id == TERMINATE_ALL || groupid == td->groupid) {
for_each_td(td, i) {
if (group_id == TERMINATE_ALL || groupid == td->groupid) {
+ dprint(FD_PROCESS, "setting terminate on %d\n",td->pid);
/*
* if the thread is running, just let it exit
*/
/*
* if the thread is running, just let it exit
*/
@@
-446,6
+449,13
@@
static void do_io(struct thread_data *td)
break;
}
break;
}
+ /*
+ * Add verification end_io handler, if asked to verify
+ * a previously written file.
+ */
+ if (td->o.verify != VERIFY_NONE)
+ io_u->end_io = verify_io_u;
+
ret = td_io_queue(td, io_u);
switch (ret) {
case FIO_Q_COMPLETED:
ret = td_io_queue(td, io_u);
switch (ret) {
case FIO_Q_COMPLETED:
@@
-561,6
+571,10
@@
sync_done:
}
}
}
}
+ if (td->o.fill_device && td->error == ENOSPC) {
+ td->error = 0;
+ td->terminate = 1;
+ }
if (!td->error) {
struct fio_file *f;
if (!td->error) {
struct fio_file *f;
@@
-579,6
+593,12
@@
sync_done:
}
} else
cleanup_pending_aio(td);
}
} else
cleanup_pending_aio(td);
+
+ /*
+ * stop job if we failed doing any IO
+ */
+ if ((td->this_io_bytes[0] + td->this_io_bytes[1]) == 0)
+ td->done = 1;
}
static void cleanup_io_u(struct thread_data *td)
}
static void cleanup_io_u(struct thread_data *td)
@@
-629,8
+649,6
@@
static int init_io_u(struct thread_data *td)
if (td->o.mem_type == MEM_SHMHUGE || td->o.mem_type == MEM_MMAPHUGE)
td->orig_buffer_size = (td->orig_buffer_size + td->o.hugepage_size - 1) & ~(td->o.hugepage_size - 1);
if (td->o.mem_type == MEM_SHMHUGE || td->o.mem_type == MEM_MMAPHUGE)
td->orig_buffer_size = (td->orig_buffer_size + td->o.hugepage_size - 1) & ~(td->o.hugepage_size - 1);
- else if (td->orig_buffer_size & page_mask)
- td->orig_buffer_size = (td->orig_buffer_size + page_mask) & ~page_mask;
if (td->orig_buffer_size != (size_t) td->orig_buffer_size) {
log_err("fio: IO memory too large. Reduce max_bs or iodepth\n");
if (td->orig_buffer_size != (size_t) td->orig_buffer_size) {
log_err("fio: IO memory too large. Reduce max_bs or iodepth\n");
@@
-640,7
+658,11
@@
static int init_io_u(struct thread_data *td)
if (allocate_io_mem(td))
return 1;
if (allocate_io_mem(td))
return 1;
- p = ALIGN(td->orig_buffer);
+ if (td->o.odirect)
+ p = ALIGN(td->orig_buffer);
+ else
+ p = td->orig_buffer;
+
for (i = 0; i < max_units; i++) {
if (td->terminate)
return 1;
for (i = 0; i < max_units; i++) {
if (td->terminate)
return 1;
@@
-648,10
+670,12
@@
static int init_io_u(struct thread_data *td)
memset(io_u, 0, sizeof(*io_u));
INIT_LIST_HEAD(&io_u->list);
memset(io_u, 0, sizeof(*io_u));
INIT_LIST_HEAD(&io_u->list);
- io_u->buf = p + max_bs * i;
+ if (!(td->io_ops->flags & FIO_NOIO)) {
+ io_u->buf = p + max_bs * i;
- if (td_write(td))
- fill_io_buf(td, io_u, max_bs);
+ if (td_write(td))
+ fill_io_buf(td, io_u, max_bs);
+ }
io_u->index = i;
io_u->flags = IO_U_F_FREE;
io_u->index = i;
io_u->flags = IO_U_F_FREE;
@@
-722,6
+746,8
@@
static int keep_running(struct thread_data *td)
{
unsigned long long io_done;
{
unsigned long long io_done;
+ if (td->done)
+ return 0;
if (td->o.time_based)
return 1;
if (td->o.loops) {
if (td->o.time_based)
return 1;
if (td->o.loops) {
@@
-729,7
+755,7
@@
static int keep_running(struct thread_data *td)
return 1;
}
return 1;
}
- io_done = td->io_bytes[DDIR_READ] + td->io_bytes[DDIR_WRITE];
+ io_done = td->io_bytes[DDIR_READ] + td->io_bytes[DDIR_WRITE]
+ td->io_skip_bytes
;
if (io_done < td->o.size)
return 1;
if (io_done < td->o.size)
return 1;
@@
-751,7
+777,11
@@
static int clear_io_state(struct thread_data *td)
td->last_was_sync = 0;
td->last_was_sync = 0;
- td->nr_done_files = 0;
+ /*
+ * reset file done count if we are to start over
+ */
+ if (td->o.time_based || td->o.loops)
+ td->nr_done_files = 0;
for_each_file(td, f, i)
td_io_close_file(td, f);
for_each_file(td, f, i)
td_io_close_file(td, f);
@@
-773,9
+803,8
@@
static int clear_io_state(struct thread_data *td)
*/
static void *thread_main(void *data)
{
*/
static void *thread_main(void *data)
{
- unsigned long long runtime[2];
+ unsigned long long runtime[2]
, elapsed
;
struct thread_data *td = data;
struct thread_data *td = data;
- unsigned long elapsed;
int clear_state;
if (!td->o.use_thread)
int clear_state;
if (!td->o.use_thread)
@@
-783,6
+812,8
@@
static void *thread_main(void *data)
td->pid = getpid();
td->pid = getpid();
+ dprint(FD_PROCESS, "jobs pid=%d started\n", td->pid);
+
INIT_LIST_HEAD(&td->io_u_freelist);
INIT_LIST_HEAD(&td->io_u_busylist);
INIT_LIST_HEAD(&td->io_u_requeues);
INIT_LIST_HEAD(&td->io_u_freelist);
INIT_LIST_HEAD(&td->io_u_busylist);
INIT_LIST_HEAD(&td->io_u_requeues);
@@
-815,7
+846,7
@@
static void *thread_main(void *data)
goto err;
}
goto err;
}
- if (td->ioprio) {
+ if (td->ioprio
_set
) {
if (ioprio_set(IOPRIO_WHO_PROCESS, 0, td->ioprio) == -1) {
td_verror(td, errno, "ioprio_set");
goto err;
if (ioprio_set(IOPRIO_WHO_PROCESS, 0, td->ioprio) == -1) {
td_verror(td, errno, "ioprio_set");
goto err;
@@
-889,7
+920,9
@@
static void *thread_main(void *data)
if (td->error || td->terminate)
break;
if (td->error || td->terminate)
break;
- if (td->o.verify == VERIFY_NONE)
+ if (!td->o.do_verify ||
+ td->o.verify == VERIFY_NONE ||
+ (td->io_ops->flags & FIO_UNIDIR))
continue;
if (clear_io_state(td))
continue;
if (clear_io_state(td))
@@
-906,8
+939,8
@@
static void *thread_main(void *data)
}
update_rusage_stat(td);
}
update_rusage_stat(td);
- td->ts.runtime[0] =
runtime[0]
/ 1000;
- td->ts.runtime[1] =
runtime[1]
/ 1000;
+ td->ts.runtime[0] =
(runtime[0] + 999)
/ 1000;
+ td->ts.runtime[1] =
(runtime[1] + 999)
/ 1000;
td->ts.total_run_time = mtime_since_now(&td->epoch);
td->ts.io_bytes[0] = td->io_bytes[0];
td->ts.io_bytes[1] = td->io_bytes[1];
td->ts.total_run_time = mtime_since_now(&td->epoch);
td->ts.io_bytes[0] = td->io_bytes[0];
td->ts.io_bytes[1] = td->io_bytes[1];
@@
-918,8
+951,6
@@
static void *thread_main(void *data)
finish_log(td, td->ts.slat_log, "slat");
if (td->ts.clat_log)
finish_log(td, td->ts.clat_log, "clat");
finish_log(td, td->ts.slat_log, "slat");
if (td->ts.clat_log)
finish_log(td, td->ts.clat_log, "clat");
- if (td->o.write_iolog_file)
- write_iolog_close(td);
if (td->o.exec_postrun) {
if (system(td->o.exec_postrun) < 0)
log_err("fio: postrun %s failed\n", td->o.exec_postrun);
if (td->o.exec_postrun) {
if (system(td->o.exec_postrun) < 0)
log_err("fio: postrun %s failed\n", td->o.exec_postrun);
@@
-934,6
+965,13
@@
err:
close_files(td);
close_ioengine(td);
cleanup_io_u(td);
close_files(td);
close_ioengine(td);
cleanup_io_u(td);
+
+ /*
+ * do this very late, it will log file closing as well
+ */
+ if (td->o.write_iolog_file)
+ write_iolog_close(td);
+
options_mem_free(td);
td_set_runstate(td, TD_EXITED);
return (void *) (unsigned long) td->error;
options_mem_free(td);
td_set_runstate(td, TD_EXITED);
return (void *) (unsigned long) td->error;
@@
-968,12
+1006,12
@@
static int fork_main(int shmid, int offset)
static void reap_threads(int *nr_running, int *t_rate, int *m_rate)
{
struct thread_data *td;
static void reap_threads(int *nr_running, int *t_rate, int *m_rate)
{
struct thread_data *td;
- int i, cputhreads, pending, status, ret;
+ int i, cputhreads,
realthreads,
pending, status, ret;
/*
* reap exited threads (TD_EXITED -> TD_REAPED)
*/
/*
* reap exited threads (TD_EXITED -> TD_REAPED)
*/
- pending = cputhreads = 0;
+
realthreads =
pending = cputhreads = 0;
for_each_td(td, i) {
int flags = 0;
for_each_td(td, i) {
int flags = 0;
@@
-983,6
+1021,8
@@
static void reap_threads(int *nr_running, int *t_rate, int *m_rate)
*/
if (td->io_ops && !strcmp(td->io_ops->name, "cpuio"))
cputhreads++;
*/
if (td->io_ops && !strcmp(td->io_ops->name, "cpuio"))
cputhreads++;
+ else
+ realthreads++;
if (!td->pid || td->runstate == TD_REAPED)
continue;
if (!td->pid || td->runstate == TD_REAPED)
continue;
@@
-1036,8
+1076,11
@@
reaped:
if (td->o.use_thread) {
long ret;
if (td->o.use_thread) {
long ret;
- if (pthread_join(td->thread, (void *) &ret))
+ dprint(FD_PROCESS, "joining tread %d\n", td->pid);
+ if (pthread_join(td->thread, (void *) &ret)) {
+ dprint(FD_PROCESS, "join failed %ld\n", ret);
perror("pthread_join");
perror("pthread_join");
+ }
}
(*nr_running)--;
}
(*nr_running)--;
@@
-1049,7
+1092,7
@@
reaped:
exit_value++;
}
exit_value++;
}
- if (*nr_running == cputhreads && !pending)
+ if (*nr_running == cputhreads && !pending
&& realthreads
)
terminate_threads(TERMINATE_ALL);
}
terminate_threads(TERMINATE_ALL);
}
@@
-1152,12
+1195,14
@@
static void run_threads(void)
nr_started++;
if (td->o.use_thread) {
nr_started++;
if (td->o.use_thread) {
+ dprint(FD_PROCESS, "will pthread_create\n");
if (pthread_create(&td->thread, NULL, thread_main, td)) {
perror("thread_create");
nr_started--;
break;
}
} else {
if (pthread_create(&td->thread, NULL, thread_main, td)) {
perror("thread_create");
nr_started--;
break;
}
} else {
+ dprint(FD_PROCESS, "will fork\n");
if (!fork()) {
int ret = fork_main(shm_id, i);
if (!fork()) {
int ret = fork_main(shm_id, i);