Merge tag 'regmap-v4.6' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie...
[linux-2.6-block.git] / tools / perf / builtin-diff.c
CommitLineData
86a9eee0
ACM
1/*
2 * builtin-diff.c
3 *
4 * Builtin diff command: Analyze two perf.data input files, look up and read
5 * DSOs and symbol information, sort them and produce a diff.
6 */
7#include "builtin.h"
8
9#include "util/debug.h"
10#include "util/event.h"
11#include "util/hist.h"
743eb868 12#include "util/evsel.h"
863e451f 13#include "util/evlist.h"
86a9eee0 14#include "util/session.h"
45694aa7 15#include "util/tool.h"
86a9eee0
ACM
16#include "util/sort.h"
17#include "util/symbol.h"
18#include "util/util.h"
f5fc1412 19#include "util/data.h"
86a9eee0
ACM
20
21#include <stdlib.h>
345dc0b4
JO
22#include <math.h>
23
24/* Diff command specific HPP columns. */
25enum {
26 PERF_HPP_DIFF__BASELINE,
27 PERF_HPP_DIFF__PERIOD,
28 PERF_HPP_DIFF__PERIOD_BASELINE,
29 PERF_HPP_DIFF__DELTA,
30 PERF_HPP_DIFF__RATIO,
31 PERF_HPP_DIFF__WEIGHTED_DIFF,
32 PERF_HPP_DIFF__FORMULA,
33
34 PERF_HPP_DIFF__MAX_INDEX
35};
36
37struct diff_hpp_fmt {
38 struct perf_hpp_fmt fmt;
39 int idx;
40 char *header;
41 int header_width;
42};
86a9eee0 43
ec308426
JO
44struct data__file {
45 struct perf_session *session;
f5fc1412 46 struct perf_data_file file;
ec308426 47 int idx;
22aeb7f5 48 struct hists *hists;
c818b498 49 struct diff_hpp_fmt fmt[PERF_HPP_DIFF__MAX_INDEX];
ec308426
JO
50};
51
52static struct data__file *data__files;
53static int data__files_cnt;
54
55#define data__for_each_file_start(i, d, s) \
56 for (i = s, d = &data__files[s]; \
57 i < data__files_cnt; \
58 i++, d = &data__files[i])
59
60#define data__for_each_file(i, d) data__for_each_file_start(i, d, 0)
22aeb7f5 61#define data__for_each_file_new(i, d) data__for_each_file_start(i, d, 1)
ec308426 62
ec308426 63static bool force;
61949b21 64static bool show_period;
ed279da2 65static bool show_formula;
a06d143e 66static bool show_baseline_only;
5f3f8d3b 67static unsigned int sort_compute;
86a9eee0 68
81d5f958
JO
69static s64 compute_wdiff_w1;
70static s64 compute_wdiff_w2;
71
7aaf6b35
JO
72enum {
73 COMPUTE_DELTA,
74 COMPUTE_RATIO,
81d5f958 75 COMPUTE_WEIGHTED_DIFF,
7aaf6b35
JO
76 COMPUTE_MAX,
77};
78
79const char *compute_names[COMPUTE_MAX] = {
80 [COMPUTE_DELTA] = "delta",
81 [COMPUTE_RATIO] = "ratio",
81d5f958 82 [COMPUTE_WEIGHTED_DIFF] = "wdiff",
7aaf6b35
JO
83};
84
85static int compute;
86
345dc0b4
JO
87static int compute_2_hpp[COMPUTE_MAX] = {
88 [COMPUTE_DELTA] = PERF_HPP_DIFF__DELTA,
89 [COMPUTE_RATIO] = PERF_HPP_DIFF__RATIO,
90 [COMPUTE_WEIGHTED_DIFF] = PERF_HPP_DIFF__WEIGHTED_DIFF,
91};
92
93#define MAX_COL_WIDTH 70
94
95static struct header_column {
96 const char *name;
97 int width;
98} columns[PERF_HPP_DIFF__MAX_INDEX] = {
99 [PERF_HPP_DIFF__BASELINE] = {
100 .name = "Baseline",
101 },
102 [PERF_HPP_DIFF__PERIOD] = {
103 .name = "Period",
104 .width = 14,
105 },
106 [PERF_HPP_DIFF__PERIOD_BASELINE] = {
107 .name = "Base period",
108 .width = 14,
109 },
110 [PERF_HPP_DIFF__DELTA] = {
111 .name = "Delta",
112 .width = 7,
113 },
114 [PERF_HPP_DIFF__RATIO] = {
115 .name = "Ratio",
116 .width = 14,
117 },
118 [PERF_HPP_DIFF__WEIGHTED_DIFF] = {
119 .name = "Weighted diff",
120 .width = 14,
121 },
122 [PERF_HPP_DIFF__FORMULA] = {
123 .name = "Formula",
124 .width = MAX_COL_WIDTH,
125 }
126};
127
81d5f958
JO
128static int setup_compute_opt_wdiff(char *opt)
129{
130 char *w1_str = opt;
131 char *w2_str;
132
133 int ret = -EINVAL;
134
135 if (!opt)
136 goto out;
137
138 w2_str = strchr(opt, ',');
139 if (!w2_str)
140 goto out;
141
142 *w2_str++ = 0x0;
143 if (!*w2_str)
144 goto out;
145
146 compute_wdiff_w1 = strtol(w1_str, NULL, 10);
147 compute_wdiff_w2 = strtol(w2_str, NULL, 10);
148
149 if (!compute_wdiff_w1 || !compute_wdiff_w2)
150 goto out;
151
152 pr_debug("compute wdiff w1(%" PRId64 ") w2(%" PRId64 ")\n",
153 compute_wdiff_w1, compute_wdiff_w2);
154
155 ret = 0;
156
157 out:
158 if (ret)
159 pr_err("Failed: wrong weight data, use 'wdiff:w1,w2'\n");
160
161 return ret;
162}
163
164static int setup_compute_opt(char *opt)
165{
166 if (compute == COMPUTE_WEIGHTED_DIFF)
167 return setup_compute_opt_wdiff(opt);
168
169 if (opt) {
170 pr_err("Failed: extra option specified '%s'", opt);
171 return -EINVAL;
172 }
173
174 return 0;
175}
176
7aaf6b35
JO
177static int setup_compute(const struct option *opt, const char *str,
178 int unset __maybe_unused)
179{
180 int *cp = (int *) opt->value;
81d5f958
JO
181 char *cstr = (char *) str;
182 char buf[50];
7aaf6b35 183 unsigned i;
81d5f958 184 char *option;
7aaf6b35
JO
185
186 if (!str) {
187 *cp = COMPUTE_DELTA;
188 return 0;
189 }
190
81d5f958
JO
191 option = strchr(str, ':');
192 if (option) {
193 unsigned len = option++ - str;
194
195 /*
196 * The str data are not writeable, so we need
197 * to use another buffer.
198 */
199
200 /* No option value is longer. */
201 if (len >= sizeof(buf))
202 return -EINVAL;
203
204 strncpy(buf, str, len);
205 buf[len] = 0x0;
206 cstr = buf;
207 }
208
7aaf6b35 209 for (i = 0; i < COMPUTE_MAX; i++)
81d5f958 210 if (!strcmp(cstr, compute_names[i])) {
7aaf6b35 211 *cp = i;
81d5f958 212 return setup_compute_opt(option);
7aaf6b35
JO
213 }
214
215 pr_err("Failed: '%s' is not computation method "
81d5f958 216 "(use 'delta','ratio' or 'wdiff')\n", str);
7aaf6b35
JO
217 return -EINVAL;
218}
219
ef358e6d 220static double period_percent(struct hist_entry *he, u64 period)
96c47f19 221{
8810f6ce
NK
222 u64 total = hists__total_period(he->hists);
223
96c47f19
JO
224 return (period * 100.0) / total;
225}
226
ef358e6d 227static double compute_delta(struct hist_entry *he, struct hist_entry *pair)
96c47f19 228{
ef358e6d
JO
229 double old_percent = period_percent(he, he->stat.period);
230 double new_percent = period_percent(pair, pair->stat.period);
96c47f19 231
9af303e2
JO
232 pair->diff.period_ratio_delta = new_percent - old_percent;
233 pair->diff.computed = true;
234 return pair->diff.period_ratio_delta;
96c47f19
JO
235}
236
ef358e6d 237static double compute_ratio(struct hist_entry *he, struct hist_entry *pair)
96c47f19 238{
9af303e2
JO
239 double old_period = he->stat.period ?: 1;
240 double new_period = pair->stat.period;
96c47f19 241
9af303e2
JO
242 pair->diff.computed = true;
243 pair->diff.period_ratio = new_period / old_period;
244 return pair->diff.period_ratio;
96c47f19
JO
245}
246
ef358e6d 247static s64 compute_wdiff(struct hist_entry *he, struct hist_entry *pair)
81d5f958 248{
9af303e2
JO
249 u64 old_period = he->stat.period;
250 u64 new_period = pair->stat.period;
81d5f958 251
9af303e2
JO
252 pair->diff.computed = true;
253 pair->diff.wdiff = new_period * compute_wdiff_w2 -
254 old_period * compute_wdiff_w1;
81d5f958 255
9af303e2 256 return pair->diff.wdiff;
81d5f958
JO
257}
258
f4c8bae1
JO
259static int formula_delta(struct hist_entry *he, struct hist_entry *pair,
260 char *buf, size_t size)
ed279da2 261{
8810f6ce
NK
262 u64 he_total = he->hists->stats.total_period;
263 u64 pair_total = pair->hists->stats.total_period;
264
265 if (symbol_conf.filter_relative) {
266 he_total = he->hists->stats.total_non_filtered_period;
267 pair_total = pair->hists->stats.total_non_filtered_period;
268 }
ed279da2
JO
269 return scnprintf(buf, size,
270 "(%" PRIu64 " * 100 / %" PRIu64 ") - "
271 "(%" PRIu64 " * 100 / %" PRIu64 ")",
8810f6ce
NK
272 pair->stat.period, pair_total,
273 he->stat.period, he_total);
ed279da2
JO
274}
275
f4c8bae1
JO
276static int formula_ratio(struct hist_entry *he, struct hist_entry *pair,
277 char *buf, size_t size)
ed279da2 278{
9af303e2
JO
279 double old_period = he->stat.period;
280 double new_period = pair->stat.period;
ed279da2
JO
281
282 return scnprintf(buf, size, "%.0F / %.0F", new_period, old_period);
283}
284
f4c8bae1
JO
285static int formula_wdiff(struct hist_entry *he, struct hist_entry *pair,
286 char *buf, size_t size)
ed279da2 287{
9af303e2
JO
288 u64 old_period = he->stat.period;
289 u64 new_period = pair->stat.period;
ed279da2
JO
290
291 return scnprintf(buf, size,
292 "(%" PRIu64 " * " "%" PRId64 ") - (%" PRIu64 " * " "%" PRId64 ")",
293 new_period, compute_wdiff_w2, old_period, compute_wdiff_w1);
294}
295
ef358e6d
JO
296static int formula_fprintf(struct hist_entry *he, struct hist_entry *pair,
297 char *buf, size_t size)
ed279da2
JO
298{
299 switch (compute) {
300 case COMPUTE_DELTA:
f4c8bae1 301 return formula_delta(he, pair, buf, size);
ed279da2 302 case COMPUTE_RATIO:
f4c8bae1 303 return formula_ratio(he, pair, buf, size);
ed279da2 304 case COMPUTE_WEIGHTED_DIFF:
f4c8bae1 305 return formula_wdiff(he, pair, buf, size);
ed279da2
JO
306 default:
307 BUG_ON(1);
308 }
309
310 return -1;
311}
312
c824c433 313static int hists__add_entry(struct hists *hists,
fd36f3dd
NK
314 struct addr_location *al,
315 struct perf_sample *sample)
86a9eee0 316{
fd36f3dd
NK
317 if (__hists__add_entry(hists, al, NULL, NULL, NULL,
318 sample, true) != NULL)
28e2a106
ACM
319 return 0;
320 return -ENOMEM;
86a9eee0
ACM
321}
322
1d037ca1 323static int diff__process_sample_event(struct perf_tool *tool __maybe_unused,
d20deb64 324 union perf_event *event,
8d50e5b4 325 struct perf_sample *sample,
863e451f 326 struct perf_evsel *evsel,
743eb868 327 struct machine *machine)
86a9eee0
ACM
328{
329 struct addr_location al;
4ea062ed 330 struct hists *hists = evsel__hists(evsel);
b91fc39f 331 int ret = -1;
86a9eee0 332
e44baa3e 333 if (perf_event__preprocess_sample(event, machine, &al, sample) < 0) {
86a9eee0
ACM
334 pr_warning("problem processing %d event, skipping it.\n",
335 event->header.type);
336 return -1;
337 }
338
fd36f3dd 339 if (hists__add_entry(hists, &al, sample)) {
c82ee828 340 pr_warning("problem incrementing symbol period, skipping event\n");
b91fc39f 341 goto out_put;
86a9eee0
ACM
342 }
343
820bc81f
NK
344 /*
345 * The total_period is updated here before going to the output
346 * tree since normally only the baseline hists will call
347 * hists__output_resort() and precompute needs the total
348 * period in order to sort entries by percentage delta.
349 */
4ea062ed 350 hists->stats.total_period += sample->period;
820bc81f 351 if (!al.filtered)
4ea062ed 352 hists->stats.total_non_filtered_period += sample->period;
b91fc39f
ACM
353 ret = 0;
354out_put:
355 addr_location__put(&al);
356 return ret;
86a9eee0
ACM
357}
358
863e451f
JO
359static struct perf_tool tool = {
360 .sample = diff__process_sample_event,
361 .mmap = perf_event__process_mmap,
68ca9d65 362 .mmap2 = perf_event__process_mmap2,
863e451f 363 .comm = perf_event__process_comm,
f62d3f0f
ACM
364 .exit = perf_event__process_exit,
365 .fork = perf_event__process_fork,
863e451f 366 .lost = perf_event__process_lost,
0a8cb85c 367 .ordered_events = true,
863e451f 368 .ordering_requires_timestamps = true,
86a9eee0
ACM
369};
370
863e451f
JO
371static struct perf_evsel *evsel_match(struct perf_evsel *evsel,
372 struct perf_evlist *evlist)
373{
374 struct perf_evsel *e;
375
0050f7aa 376 evlist__for_each(evlist, e) {
863e451f
JO
377 if (perf_evsel__match2(evsel, e))
378 return e;
0050f7aa 379 }
863e451f
JO
380
381 return NULL;
382}
383
ce74f60e 384static void perf_evlist__collapse_resort(struct perf_evlist *evlist)
dd464345
JO
385{
386 struct perf_evsel *evsel;
387
0050f7aa 388 evlist__for_each(evlist, evsel) {
4ea062ed 389 struct hists *hists = evsel__hists(evsel);
dd464345 390
c1fb5651 391 hists__collapse_resort(hists, NULL);
dd464345
JO
392 }
393}
394
ff21cef6
NK
395static struct data__file *fmt_to_data_file(struct perf_hpp_fmt *fmt)
396{
397 struct diff_hpp_fmt *dfmt = container_of(fmt, struct diff_hpp_fmt, fmt);
398 void *ptr = dfmt - dfmt->idx;
399 struct data__file *d = container_of(ptr, struct data__file, fmt);
400
401 return d;
402}
403
5f3f8d3b
JO
404static struct hist_entry*
405get_pair_data(struct hist_entry *he, struct data__file *d)
406{
407 if (hist_entry__has_pairs(he)) {
408 struct hist_entry *pair;
409
410 list_for_each_entry(pair, &he->pairs.head, pairs.node)
411 if (pair->hists == d->hists)
412 return pair;
413 }
414
415 return NULL;
416}
417
418static struct hist_entry*
419get_pair_fmt(struct hist_entry *he, struct diff_hpp_fmt *dfmt)
420{
ff21cef6 421 struct data__file *d = fmt_to_data_file(&dfmt->fmt);
5f3f8d3b
JO
422
423 return get_pair_data(he, d);
424}
425
a06d143e
JO
426static void hists__baseline_only(struct hists *hists)
427{
ce74f60e
NK
428 struct rb_root *root;
429 struct rb_node *next;
430
431 if (sort__need_collapse)
432 root = &hists->entries_collapsed;
433 else
434 root = hists->entries_in;
a06d143e 435
ce74f60e 436 next = rb_first(root);
a06d143e 437 while (next != NULL) {
ce74f60e 438 struct hist_entry *he = rb_entry(next, struct hist_entry, rb_node_in);
a06d143e 439
ce74f60e 440 next = rb_next(&he->rb_node_in);
b821c732 441 if (!hist_entry__next_pair(he)) {
ce74f60e 442 rb_erase(&he->rb_node_in, root);
6733d1bf 443 hist_entry__delete(he);
a06d143e
JO
444 }
445 }
446}
447
96c47f19
JO
448static void hists__precompute(struct hists *hists)
449{
367c53c0
JO
450 struct rb_root *root;
451 struct rb_node *next;
452
453 if (sort__need_collapse)
454 root = &hists->entries_collapsed;
455 else
456 root = hists->entries_in;
96c47f19 457
367c53c0 458 next = rb_first(root);
96c47f19 459 while (next != NULL) {
5f3f8d3b 460 struct hist_entry *he, *pair;
56495a8a
NK
461 struct data__file *d;
462 int i;
96c47f19 463
5f3f8d3b 464 he = rb_entry(next, struct hist_entry, rb_node_in);
367c53c0 465 next = rb_next(&he->rb_node_in);
5f3f8d3b 466
56495a8a
NK
467 data__for_each_file_new(i, d) {
468 pair = get_pair_data(he, d);
469 if (!pair)
470 continue;
471
472 switch (compute) {
473 case COMPUTE_DELTA:
474 compute_delta(he, pair);
475 break;
476 case COMPUTE_RATIO:
477 compute_ratio(he, pair);
478 break;
479 case COMPUTE_WEIGHTED_DIFF:
480 compute_wdiff(he, pair);
481 break;
482 default:
483 BUG_ON(1);
484 }
96c47f19
JO
485 }
486 }
487}
488
489static int64_t cmp_doubles(double l, double r)
490{
491 if (l > r)
492 return -1;
493 else if (l < r)
494 return 1;
495 else
496 return 0;
497}
498
499static int64_t
5f3f8d3b 500__hist_entry__cmp_compute(struct hist_entry *left, struct hist_entry *right,
96c47f19
JO
501 int c)
502{
503 switch (c) {
504 case COMPUTE_DELTA:
505 {
506 double l = left->diff.period_ratio_delta;
507 double r = right->diff.period_ratio_delta;
508
509 return cmp_doubles(l, r);
510 }
511 case COMPUTE_RATIO:
512 {
513 double l = left->diff.period_ratio;
514 double r = right->diff.period_ratio;
515
516 return cmp_doubles(l, r);
517 }
81d5f958
JO
518 case COMPUTE_WEIGHTED_DIFF:
519 {
520 s64 l = left->diff.wdiff;
521 s64 r = right->diff.wdiff;
522
523 return r - l;
524 }
96c47f19
JO
525 default:
526 BUG_ON(1);
527 }
528
529 return 0;
530}
531
5f3f8d3b
JO
532static int64_t
533hist_entry__cmp_compute(struct hist_entry *left, struct hist_entry *right,
56495a8a 534 int c, int sort_idx)
5f3f8d3b
JO
535{
536 bool pairs_left = hist_entry__has_pairs(left);
537 bool pairs_right = hist_entry__has_pairs(right);
538 struct hist_entry *p_right, *p_left;
539
540 if (!pairs_left && !pairs_right)
541 return 0;
542
543 if (!pairs_left || !pairs_right)
544 return pairs_left ? -1 : 1;
545
56495a8a
NK
546 p_left = get_pair_data(left, &data__files[sort_idx]);
547 p_right = get_pair_data(right, &data__files[sort_idx]);
5f3f8d3b
JO
548
549 if (!p_left && !p_right)
550 return 0;
551
552 if (!p_left || !p_right)
553 return p_left ? -1 : 1;
554
555 /*
556 * We have 2 entries of same kind, let's
557 * make the data comparison.
558 */
559 return __hist_entry__cmp_compute(p_left, p_right, c);
560}
561
566b5cfb
NK
562static int64_t
563hist_entry__cmp_compute_idx(struct hist_entry *left, struct hist_entry *right,
564 int c, int sort_idx)
565{
566 struct hist_entry *p_right, *p_left;
567
568 p_left = get_pair_data(left, &data__files[sort_idx]);
569 p_right = get_pair_data(right, &data__files[sort_idx]);
570
571 if (!p_left && !p_right)
572 return 0;
573
574 if (!p_left || !p_right)
575 return p_left ? -1 : 1;
576
577 if (c != COMPUTE_DELTA) {
578 /*
579 * The delta can be computed without the baseline, but
580 * others are not. Put those entries which have no
581 * values below.
582 */
583 if (left->dummy && right->dummy)
584 return 0;
585
586 if (left->dummy || right->dummy)
587 return left->dummy ? 1 : -1;
588 }
589
590 return __hist_entry__cmp_compute(p_left, p_right, c);
591}
592
e7024fc3 593static int64_t
87bbdf76
NK
594hist_entry__cmp_nop(struct perf_hpp_fmt *fmt __maybe_unused,
595 struct hist_entry *left __maybe_unused,
e7024fc3
NK
596 struct hist_entry *right __maybe_unused)
597{
598 return 0;
599}
600
601static int64_t
87bbdf76
NK
602hist_entry__cmp_baseline(struct perf_hpp_fmt *fmt __maybe_unused,
603 struct hist_entry *left, struct hist_entry *right)
e7024fc3 604{
e7024fc3
NK
605 if (left->stat.period == right->stat.period)
606 return 0;
607 return left->stat.period > right->stat.period ? 1 : -1;
608}
609
610static int64_t
56495a8a 611hist_entry__cmp_delta(struct perf_hpp_fmt *fmt,
87bbdf76 612 struct hist_entry *left, struct hist_entry *right)
e7024fc3 613{
56495a8a
NK
614 struct data__file *d = fmt_to_data_file(fmt);
615
616 return hist_entry__cmp_compute(right, left, COMPUTE_DELTA, d->idx);
e7024fc3
NK
617}
618
619static int64_t
56495a8a 620hist_entry__cmp_ratio(struct perf_hpp_fmt *fmt,
87bbdf76 621 struct hist_entry *left, struct hist_entry *right)
e7024fc3 622{
56495a8a
NK
623 struct data__file *d = fmt_to_data_file(fmt);
624
625 return hist_entry__cmp_compute(right, left, COMPUTE_RATIO, d->idx);
e7024fc3
NK
626}
627
628static int64_t
56495a8a 629hist_entry__cmp_wdiff(struct perf_hpp_fmt *fmt,
87bbdf76 630 struct hist_entry *left, struct hist_entry *right)
e7024fc3 631{
56495a8a
NK
632 struct data__file *d = fmt_to_data_file(fmt);
633
634 return hist_entry__cmp_compute(right, left, COMPUTE_WEIGHTED_DIFF, d->idx);
e7024fc3
NK
635}
636
566b5cfb
NK
637static int64_t
638hist_entry__cmp_delta_idx(struct perf_hpp_fmt *fmt __maybe_unused,
639 struct hist_entry *left, struct hist_entry *right)
640{
641 return hist_entry__cmp_compute_idx(right, left, COMPUTE_DELTA,
642 sort_compute);
643}
644
645static int64_t
646hist_entry__cmp_ratio_idx(struct perf_hpp_fmt *fmt __maybe_unused,
647 struct hist_entry *left, struct hist_entry *right)
648{
649 return hist_entry__cmp_compute_idx(right, left, COMPUTE_RATIO,
650 sort_compute);
651}
652
653static int64_t
654hist_entry__cmp_wdiff_idx(struct perf_hpp_fmt *fmt __maybe_unused,
655 struct hist_entry *left, struct hist_entry *right)
656{
657 return hist_entry__cmp_compute_idx(right, left, COMPUTE_WEIGHTED_DIFF,
658 sort_compute);
659}
660
22aeb7f5 661static void hists__process(struct hists *hists)
a06d143e 662{
a06d143e 663 if (show_baseline_only)
22aeb7f5 664 hists__baseline_only(hists);
a06d143e 665
56495a8a 666 hists__precompute(hists);
38259a17 667 hists__output_resort(hists, NULL);
96c47f19 668
22aeb7f5 669 hists__fprintf(hists, true, 0, 0, 0, stdout);
a06d143e
JO
670}
671
1d81c7fc
JO
672static void data__fprintf(void)
673{
674 struct data__file *d;
675 int i;
676
677 fprintf(stdout, "# Data files:\n");
678
679 data__for_each_file(i, d)
680 fprintf(stdout, "# [%d] %s %s\n",
f5fc1412 681 d->idx, d->file.path,
1d81c7fc
JO
682 !d->idx ? "(Baseline)" : "");
683
684 fprintf(stdout, "#\n");
685}
686
ec308426 687static void data_process(void)
86a9eee0 688{
22aeb7f5
JO
689 struct perf_evlist *evlist_base = data__files[0].session->evlist;
690 struct perf_evsel *evsel_base;
863e451f 691 bool first = true;
86a9eee0 692
0050f7aa 693 evlist__for_each(evlist_base, evsel_base) {
4ea062ed 694 struct hists *hists_base = evsel__hists(evsel_base);
22aeb7f5
JO
695 struct data__file *d;
696 int i;
86a9eee0 697
22aeb7f5
JO
698 data__for_each_file_new(i, d) {
699 struct perf_evlist *evlist = d->session->evlist;
700 struct perf_evsel *evsel;
4ea062ed 701 struct hists *hists;
22aeb7f5
JO
702
703 evsel = evsel_match(evsel_base, evlist);
704 if (!evsel)
705 continue;
706
4ea062ed
ACM
707 hists = evsel__hists(evsel);
708 d->hists = hists;
22aeb7f5 709
4ea062ed 710 hists__match(hists_base, hists);
22aeb7f5
JO
711
712 if (!show_baseline_only)
4ea062ed 713 hists__link(hists_base, hists);
22aeb7f5 714 }
86a9eee0 715
ec308426 716 fprintf(stdout, "%s# Event '%s'\n#\n", first ? "" : "\n",
22aeb7f5 717 perf_evsel__name(evsel_base));
863e451f 718
ec308426 719 first = false;
863e451f 720
22aeb7f5 721 if (verbose || data__files_cnt > 2)
1d81c7fc
JO
722 data__fprintf();
723
f9db0d0f
KL
724 /* Don't sort callchain for perf diff */
725 perf_evsel__reset_sample_bit(evsel_base, CALLCHAIN);
726
4ea062ed 727 hists__process(hists_base);
ec308426
JO
728 }
729}
863e451f 730
c818b498
JO
731static void data__free(struct data__file *d)
732{
733 int col;
734
735 for (col = 0; col < PERF_HPP_DIFF__MAX_INDEX; col++) {
736 struct diff_hpp_fmt *fmt = &d->fmt[col];
737
74cf249d 738 zfree(&fmt->header);
c818b498
JO
739 }
740}
741
ec308426
JO
742static int __cmd_diff(void)
743{
744 struct data__file *d;
745 int ret = -EINVAL, i;
746
747 data__for_each_file(i, d) {
f5fc1412 748 d->session = perf_session__new(&d->file, false, &tool);
ec308426 749 if (!d->session) {
f5fc1412 750 pr_err("Failed to open %s\n", d->file.path);
52e02834 751 ret = -1;
ec308426
JO
752 goto out_delete;
753 }
863e451f 754
b7b61cbe 755 ret = perf_session__process_events(d->session);
ec308426 756 if (ret) {
f5fc1412 757 pr_err("Failed to process %s\n", d->file.path);
ec308426
JO
758 goto out_delete;
759 }
863e451f 760
ec308426
JO
761 perf_evlist__collapse_resort(d->session->evlist);
762 }
763
764 data_process();
863e451f 765
ec308426
JO
766 out_delete:
767 data__for_each_file(i, d) {
768 if (d->session)
769 perf_session__delete(d->session);
c818b498
JO
770
771 data__free(d);
863e451f 772 }
9c443dfd 773
ec308426 774 free(data__files);
86a9eee0
ACM
775 return ret;
776}
777
0422a4fc 778static const char * const diff_usage[] = {
86a9eee0 779 "perf diff [<options>] [old_file] [new_file]",
0422a4fc 780 NULL,
86a9eee0
ACM
781};
782
783static const struct option options[] = {
c0555642 784 OPT_INCR('v', "verbose", &verbose,
86a9eee0 785 "be more verbose (show symbol address, etc)"),
a06d143e
JO
786 OPT_BOOLEAN('b', "baseline-only", &show_baseline_only,
787 "Show only items with match in baseline"),
81d5f958
JO
788 OPT_CALLBACK('c', "compute", &compute,
789 "delta,ratio,wdiff:w1,w2 (default delta)",
7aaf6b35
JO
790 "Entries differential computation selection",
791 setup_compute),
61949b21
JO
792 OPT_BOOLEAN('p', "period", &show_period,
793 "Show period values."),
ed279da2
JO
794 OPT_BOOLEAN('F', "formula", &show_formula,
795 "Show formula."),
86a9eee0
ACM
796 OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace,
797 "dump raw trace in ASCII"),
798 OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
6b1f3423
DA
799 OPT_STRING(0, "kallsyms", &symbol_conf.kallsyms_name,
800 "file", "kallsyms pathname"),
86a9eee0
ACM
801 OPT_BOOLEAN('m', "modules", &symbol_conf.use_modules,
802 "load module symbols - WARNING: use only with -k and LIVE kernel"),
c410a338
ACM
803 OPT_STRING('d', "dsos", &symbol_conf.dso_list_str, "dso[,dso...]",
804 "only consider symbols in these dsos"),
805 OPT_STRING('C', "comms", &symbol_conf.comm_list_str, "comm[,comm...]",
806 "only consider symbols in these comms"),
807 OPT_STRING('S', "symbols", &symbol_conf.sym_list_str, "symbol[,symbol...]",
808 "only consider these symbols"),
c351c281 809 OPT_STRING('s', "sort", &sort_order, "key[,key2...]",
a2ce067e
NK
810 "sort by key(s): pid, comm, dso, symbol, parent, cpu, srcline, ..."
811 " Please refer the man page for the complete list."),
8b8ca6e1 812 OPT_STRING_NOEMPTY('t', "field-separator", &symbol_conf.field_sep, "separator",
c351c281
ACM
813 "separator for columns, no spaces will be added between "
814 "columns '.' is reserved."),
ec5761ea
DA
815 OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory",
816 "Look for files with symbols relative to this directory"),
5f3f8d3b 817 OPT_UINTEGER('o', "order", &sort_compute, "Specify compute sorting."),
8810f6ce
NK
818 OPT_CALLBACK(0, "percentage", NULL, "relative|absolute",
819 "How to display percentage of filtered entries", parse_filter_percentage),
86a9eee0
ACM
820 OPT_END()
821};
822
345dc0b4 823static double baseline_percent(struct hist_entry *he)
1d77822e 824{
8810f6ce
NK
825 u64 total = hists__total_period(he->hists);
826
827 return 100.0 * he->stat.period / total;
345dc0b4 828}
7aaf6b35 829
345dc0b4
JO
830static int hpp__color_baseline(struct perf_hpp_fmt *fmt,
831 struct perf_hpp *hpp, struct hist_entry *he)
832{
833 struct diff_hpp_fmt *dfmt =
834 container_of(fmt, struct diff_hpp_fmt, fmt);
835 double percent = baseline_percent(he);
836 char pfmt[20] = " ";
837
838 if (!he->dummy) {
839 scnprintf(pfmt, 20, "%%%d.2f%%%%", dfmt->header_width - 1);
840 return percent_color_snprintf(hpp->buf, hpp->size,
841 pfmt, percent);
842 } else
843 return scnprintf(hpp->buf, hpp->size, "%*s",
844 dfmt->header_width, pfmt);
845}
846
847static int hpp__entry_baseline(struct hist_entry *he, char *buf, size_t size)
848{
849 double percent = baseline_percent(he);
850 const char *fmt = symbol_conf.field_sep ? "%.2f" : "%6.2f%%";
851 int ret = 0;
852
853 if (!he->dummy)
854 ret = scnprintf(buf, size, fmt, percent);
855
856 return ret;
857}
858
01f10bc8
RR
859static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
860 struct perf_hpp *hpp, struct hist_entry *he,
861 int comparison_method)
862{
863 struct diff_hpp_fmt *dfmt =
864 container_of(fmt, struct diff_hpp_fmt, fmt);
865 struct hist_entry *pair = get_pair_fmt(he, dfmt);
866 double diff;
a5846e21 867 s64 wdiff;
01f10bc8
RR
868 char pfmt[20] = " ";
869
870 if (!pair)
ec3d07cb 871 goto no_print;
01f10bc8
RR
872
873 switch (comparison_method) {
874 case COMPUTE_DELTA:
875 if (pair->diff.computed)
876 diff = pair->diff.period_ratio_delta;
877 else
878 diff = compute_delta(he, pair);
879
01f10bc8
RR
880 scnprintf(pfmt, 20, "%%%+d.2f%%%%", dfmt->header_width - 1);
881 return percent_color_snprintf(hpp->buf, hpp->size,
882 pfmt, diff);
1f513b2c
RR
883 case COMPUTE_RATIO:
884 if (he->dummy)
885 goto dummy_print;
886 if (pair->diff.computed)
887 diff = pair->diff.period_ratio;
888 else
889 diff = compute_ratio(he, pair);
890
891 scnprintf(pfmt, 20, "%%%d.6f", dfmt->header_width);
892 return value_color_snprintf(hpp->buf, hpp->size,
893 pfmt, diff);
a5846e21
RR
894 case COMPUTE_WEIGHTED_DIFF:
895 if (he->dummy)
896 goto dummy_print;
897 if (pair->diff.computed)
898 wdiff = pair->diff.wdiff;
899 else
900 wdiff = compute_wdiff(he, pair);
901
902 scnprintf(pfmt, 20, "%%14ld", dfmt->header_width);
903 return color_snprintf(hpp->buf, hpp->size,
904 get_percent_color(wdiff),
905 pfmt, wdiff);
01f10bc8
RR
906 default:
907 BUG_ON(1);
908 }
909dummy_print:
ec3d07cb
NK
910 return scnprintf(hpp->buf, hpp->size, "%*s",
911 dfmt->header_width, "N/A");
912no_print:
01f10bc8
RR
913 return scnprintf(hpp->buf, hpp->size, "%*s",
914 dfmt->header_width, pfmt);
915}
916
917static int hpp__color_delta(struct perf_hpp_fmt *fmt,
918 struct perf_hpp *hpp, struct hist_entry *he)
919{
920 return __hpp__color_compare(fmt, hpp, he, COMPUTE_DELTA);
921}
922
1f513b2c
RR
923static int hpp__color_ratio(struct perf_hpp_fmt *fmt,
924 struct perf_hpp *hpp, struct hist_entry *he)
925{
926 return __hpp__color_compare(fmt, hpp, he, COMPUTE_RATIO);
927}
928
a5846e21
RR
929static int hpp__color_wdiff(struct perf_hpp_fmt *fmt,
930 struct perf_hpp *hpp, struct hist_entry *he)
931{
932 return __hpp__color_compare(fmt, hpp, he, COMPUTE_WEIGHTED_DIFF);
933}
934
345dc0b4
JO
935static void
936hpp__entry_unpair(struct hist_entry *he, int idx, char *buf, size_t size)
937{
938 switch (idx) {
939 case PERF_HPP_DIFF__PERIOD_BASELINE:
940 scnprintf(buf, size, "%" PRIu64, he->stat.period);
7aaf6b35 941 break;
345dc0b4
JO
942
943 default:
81d5f958 944 break;
345dc0b4
JO
945 }
946}
947
948static void
949hpp__entry_pair(struct hist_entry *he, struct hist_entry *pair,
950 int idx, char *buf, size_t size)
951{
952 double diff;
953 double ratio;
954 s64 wdiff;
955
956 switch (idx) {
957 case PERF_HPP_DIFF__DELTA:
958 if (pair->diff.computed)
959 diff = pair->diff.period_ratio_delta;
960 else
ef358e6d 961 diff = compute_delta(he, pair);
345dc0b4 962
ec3d07cb 963 scnprintf(buf, size, "%+4.2F%%", diff);
345dc0b4
JO
964 break;
965
966 case PERF_HPP_DIFF__RATIO:
967 /* No point for ratio number if we are dummy.. */
ec3d07cb
NK
968 if (he->dummy) {
969 scnprintf(buf, size, "N/A");
345dc0b4 970 break;
ec3d07cb 971 }
345dc0b4
JO
972
973 if (pair->diff.computed)
974 ratio = pair->diff.period_ratio;
975 else
ef358e6d 976 ratio = compute_ratio(he, pair);
345dc0b4
JO
977
978 if (ratio > 0.0)
979 scnprintf(buf, size, "%14.6F", ratio);
980 break;
981
982 case PERF_HPP_DIFF__WEIGHTED_DIFF:
983 /* No point for wdiff number if we are dummy.. */
ec3d07cb
NK
984 if (he->dummy) {
985 scnprintf(buf, size, "N/A");
345dc0b4 986 break;
ec3d07cb 987 }
345dc0b4
JO
988
989 if (pair->diff.computed)
990 wdiff = pair->diff.wdiff;
991 else
ef358e6d 992 wdiff = compute_wdiff(he, pair);
345dc0b4
JO
993
994 if (wdiff != 0)
995 scnprintf(buf, size, "%14ld", wdiff);
996 break;
997
998 case PERF_HPP_DIFF__FORMULA:
ef358e6d 999 formula_fprintf(he, pair, buf, size);
7aaf6b35 1000 break;
345dc0b4
JO
1001
1002 case PERF_HPP_DIFF__PERIOD:
1003 scnprintf(buf, size, "%" PRIu64, pair->stat.period);
1004 break;
1005
7aaf6b35
JO
1006 default:
1007 BUG_ON(1);
1008 };
345dc0b4
JO
1009}
1010
1011static void
22aeb7f5
JO
1012__hpp__entry_global(struct hist_entry *he, struct diff_hpp_fmt *dfmt,
1013 char *buf, size_t size)
345dc0b4 1014{
5f3f8d3b 1015 struct hist_entry *pair = get_pair_fmt(he, dfmt);
22aeb7f5 1016 int idx = dfmt->idx;
345dc0b4
JO
1017
1018 /* baseline is special */
1019 if (idx == PERF_HPP_DIFF__BASELINE)
1020 hpp__entry_baseline(he, buf, size);
1021 else {
1022 if (pair)
1023 hpp__entry_pair(he, pair, idx, buf, size);
1024 else
1025 hpp__entry_unpair(he, idx, buf, size);
1026 }
1027}
1028
1029static int hpp__entry_global(struct perf_hpp_fmt *_fmt, struct perf_hpp *hpp,
1030 struct hist_entry *he)
1031{
1032 struct diff_hpp_fmt *dfmt =
1033 container_of(_fmt, struct diff_hpp_fmt, fmt);
1034 char buf[MAX_COL_WIDTH] = " ";
1035
22aeb7f5 1036 __hpp__entry_global(he, dfmt, buf, MAX_COL_WIDTH);
345dc0b4
JO
1037
1038 if (symbol_conf.field_sep)
1039 return scnprintf(hpp->buf, hpp->size, "%s", buf);
1040 else
1041 return scnprintf(hpp->buf, hpp->size, "%*s",
1042 dfmt->header_width, buf);
1043}
1044
94a0793d
NK
1045static int hpp__header(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
1046 struct perf_evsel *evsel __maybe_unused)
345dc0b4
JO
1047{
1048 struct diff_hpp_fmt *dfmt =
1049 container_of(fmt, struct diff_hpp_fmt, fmt);
1050
1051 BUG_ON(!dfmt->header);
1052 return scnprintf(hpp->buf, hpp->size, dfmt->header);
1053}
1054
1055static int hpp__width(struct perf_hpp_fmt *fmt,
94a0793d
NK
1056 struct perf_hpp *hpp __maybe_unused,
1057 struct perf_evsel *evsel __maybe_unused)
345dc0b4
JO
1058{
1059 struct diff_hpp_fmt *dfmt =
1060 container_of(fmt, struct diff_hpp_fmt, fmt);
1061
1062 BUG_ON(dfmt->header_width <= 0);
1063 return dfmt->header_width;
1064}
1065
22aeb7f5 1066static void init_header(struct data__file *d, struct diff_hpp_fmt *dfmt)
345dc0b4
JO
1067{
1068#define MAX_HEADER_NAME 100
1069 char buf_indent[MAX_HEADER_NAME];
1070 char buf[MAX_HEADER_NAME];
1071 const char *header = NULL;
1072 int width = 0;
1073
1074 BUG_ON(dfmt->idx >= PERF_HPP_DIFF__MAX_INDEX);
1075 header = columns[dfmt->idx].name;
1076 width = columns[dfmt->idx].width;
1077
1078 /* Only our defined HPP fmts should appear here. */
1079 BUG_ON(!header);
1080
22aeb7f5
JO
1081 if (data__files_cnt > 2)
1082 scnprintf(buf, MAX_HEADER_NAME, "%s/%d", header, d->idx);
1083
345dc0b4
JO
1084#define NAME (data__files_cnt > 2 ? buf : header)
1085 dfmt->header_width = width;
1086 width = (int) strlen(NAME);
1087 if (dfmt->header_width < width)
1088 dfmt->header_width = width;
1089
1090 scnprintf(buf_indent, MAX_HEADER_NAME, "%*s",
1091 dfmt->header_width, NAME);
1092
1093 dfmt->header = strdup(buf_indent);
1094#undef MAX_HEADER_NAME
1095#undef NAME
1096}
1097
c818b498 1098static void data__hpp_register(struct data__file *d, int idx)
345dc0b4 1099{
c818b498
JO
1100 struct diff_hpp_fmt *dfmt = &d->fmt[idx];
1101 struct perf_hpp_fmt *fmt = &dfmt->fmt;
1102
1103 dfmt->idx = idx;
1104
1105 fmt->header = hpp__header;
1106 fmt->width = hpp__width;
1107 fmt->entry = hpp__entry_global;
e7024fc3
NK
1108 fmt->cmp = hist_entry__cmp_nop;
1109 fmt->collapse = hist_entry__cmp_nop;
c818b498
JO
1110
1111 /* TODO more colors */
01f10bc8
RR
1112 switch (idx) {
1113 case PERF_HPP_DIFF__BASELINE:
c818b498 1114 fmt->color = hpp__color_baseline;
e7024fc3 1115 fmt->sort = hist_entry__cmp_baseline;
01f10bc8
RR
1116 break;
1117 case PERF_HPP_DIFF__DELTA:
1118 fmt->color = hpp__color_delta;
e7024fc3 1119 fmt->sort = hist_entry__cmp_delta;
01f10bc8 1120 break;
1f513b2c
RR
1121 case PERF_HPP_DIFF__RATIO:
1122 fmt->color = hpp__color_ratio;
e7024fc3 1123 fmt->sort = hist_entry__cmp_ratio;
1f513b2c 1124 break;
a5846e21
RR
1125 case PERF_HPP_DIFF__WEIGHTED_DIFF:
1126 fmt->color = hpp__color_wdiff;
e7024fc3 1127 fmt->sort = hist_entry__cmp_wdiff;
a5846e21 1128 break;
01f10bc8 1129 default:
e7024fc3 1130 fmt->sort = hist_entry__cmp_nop;
01f10bc8
RR
1131 break;
1132 }
345dc0b4 1133
22aeb7f5 1134 init_header(d, dfmt);
c818b498 1135 perf_hpp__column_register(fmt);
e7024fc3 1136 perf_hpp__register_sort_field(fmt);
345dc0b4
JO
1137}
1138
566b5cfb 1139static int ui_init(void)
345dc0b4 1140{
c818b498 1141 struct data__file *d;
566b5cfb 1142 struct perf_hpp_fmt *fmt;
c818b498
JO
1143 int i;
1144
1145 data__for_each_file(i, d) {
1146
1147 /*
1148 * Baseline or compute realted columns:
1149 *
1150 * PERF_HPP_DIFF__BASELINE
1151 * PERF_HPP_DIFF__DELTA
1152 * PERF_HPP_DIFF__RATIO
1153 * PERF_HPP_DIFF__WEIGHTED_DIFF
1154 */
1155 data__hpp_register(d, i ? compute_2_hpp[compute] :
1156 PERF_HPP_DIFF__BASELINE);
1d77822e 1157
c818b498
JO
1158 /*
1159 * And the rest:
1160 *
1161 * PERF_HPP_DIFF__FORMULA
1162 * PERF_HPP_DIFF__PERIOD
1163 * PERF_HPP_DIFF__PERIOD_BASELINE
1164 */
1165 if (show_formula && i)
1166 data__hpp_register(d, PERF_HPP_DIFF__FORMULA);
ed279da2 1167
c818b498
JO
1168 if (show_period)
1169 data__hpp_register(d, i ? PERF_HPP_DIFF__PERIOD :
1170 PERF_HPP_DIFF__PERIOD_BASELINE);
61949b21 1171 }
566b5cfb
NK
1172
1173 if (!sort_compute)
1174 return 0;
1175
1176 /*
1177 * Prepend an fmt to sort on columns at 'sort_compute' first.
1178 * This fmt is added only to the sort list but not to the
1179 * output fields list.
1180 *
1181 * Note that this column (data) can be compared twice - one
1182 * for this 'sort_compute' fmt and another for the normal
1183 * diff_hpp_fmt. But it shouldn't a problem as most entries
1184 * will be sorted out by first try or baseline and comparing
1185 * is not a costly operation.
1186 */
1187 fmt = zalloc(sizeof(*fmt));
1188 if (fmt == NULL) {
1189 pr_err("Memory allocation failed\n");
1190 return -1;
1191 }
1192
1193 fmt->cmp = hist_entry__cmp_nop;
1194 fmt->collapse = hist_entry__cmp_nop;
1195
1196 switch (compute) {
1197 case COMPUTE_DELTA:
1198 fmt->sort = hist_entry__cmp_delta_idx;
1199 break;
1200 case COMPUTE_RATIO:
1201 fmt->sort = hist_entry__cmp_ratio_idx;
1202 break;
1203 case COMPUTE_WEIGHTED_DIFF:
1204 fmt->sort = hist_entry__cmp_wdiff_idx;
1205 break;
1206 default:
1207 BUG_ON(1);
1208 }
1209
21e6d842 1210 perf_hpp__register_sort_field(fmt);
566b5cfb 1211 return 0;
1d77822e
JO
1212}
1213
ec308426 1214static int data_init(int argc, const char **argv)
86a9eee0 1215{
ec308426
JO
1216 struct data__file *d;
1217 static const char *defaults[] = {
1218 "perf.data.old",
1219 "perf.data",
1220 };
22aeb7f5 1221 bool use_default = true;
ec308426
JO
1222 int i;
1223
1224 data__files_cnt = 2;
1225
86a9eee0 1226 if (argc) {
22aeb7f5 1227 if (argc == 1)
ec308426 1228 defaults[1] = argv[0];
22aeb7f5
JO
1229 else {
1230 data__files_cnt = argc;
1231 use_default = false;
1232 }
d8d9608f 1233 } else if (perf_guest) {
ec308426
JO
1234 defaults[0] = "perf.data.host";
1235 defaults[1] = "perf.data.guest";
86a9eee0
ACM
1236 }
1237
5f3f8d3b
JO
1238 if (sort_compute >= (unsigned int) data__files_cnt) {
1239 pr_err("Order option out of limit.\n");
1240 return -EINVAL;
1241 }
1242
ec308426
JO
1243 data__files = zalloc(sizeof(*data__files) * data__files_cnt);
1244 if (!data__files)
1245 return -ENOMEM;
1246
1247 data__for_each_file(i, d) {
f5fc1412
JO
1248 struct perf_data_file *file = &d->file;
1249
1250 file->path = use_default ? defaults[i] : argv[i];
1251 file->mode = PERF_DATA_MODE_READ,
1252 file->force = force,
1253
ec308426
JO
1254 d->idx = i;
1255 }
1256
1257 return 0;
1258}
1259
1260int cmd_diff(int argc, const char **argv, const char *prefix __maybe_unused)
1261{
9ab1f508
KL
1262 int ret = hists__init();
1263
1264 if (ret < 0)
1265 return ret;
1266
ec308426
JO
1267 argc = parse_options(argc, argv, options, diff_usage, 0);
1268
0a7e6d1b 1269 if (symbol__init(NULL) < 0)
655000e7
ACM
1270 return -1;
1271
ec308426
JO
1272 if (data_init(argc, argv) < 0)
1273 return -1;
1274
566b5cfb
NK
1275 if (ui_init() < 0)
1276 return -1;
1d77822e 1277
512ae1bd
NK
1278 sort__mode = SORT_MODE__DIFF;
1279
40184c46 1280 if (setup_sorting(NULL) < 0)
55309985
NK
1281 usage_with_options(diff_usage, options);
1282
86a9eee0 1283 setup_pager();
c351c281 1284
08e71542 1285 sort__setup_elide(NULL);
c351c281 1286
86a9eee0
ACM
1287 return __cmd_diff();
1288}