device_cgroup: introduce dev_whitelist_clean()
[linux-2.6-block.git] / security / device_cgroup.c
CommitLineData
08ce5f16 1/*
47c59803 2 * device_cgroup.c - device cgroup subsystem
08ce5f16
SH
3 *
4 * Copyright 2007 IBM Corp
5 */
6
7#include <linux/device_cgroup.h>
8#include <linux/cgroup.h>
9#include <linux/ctype.h>
10#include <linux/list.h>
11#include <linux/uaccess.h>
29486df3 12#include <linux/seq_file.h>
5a0e3ad6 13#include <linux/slab.h>
47c59803 14#include <linux/rcupdate.h>
b4046f00 15#include <linux/mutex.h>
08ce5f16
SH
16
17#define ACC_MKNOD 1
18#define ACC_READ 2
19#define ACC_WRITE 4
20#define ACC_MASK (ACC_MKNOD | ACC_READ | ACC_WRITE)
21
22#define DEV_BLOCK 1
23#define DEV_CHAR 2
24#define DEV_ALL 4 /* this represents all devices */
25
b4046f00
LZ
26static DEFINE_MUTEX(devcgroup_mutex);
27
08ce5f16
SH
28/*
29 * whitelist locking rules:
b4046f00 30 * hold devcgroup_mutex for update/read.
47c59803 31 * hold rcu_read_lock() for read.
08ce5f16
SH
32 */
33
34struct dev_whitelist_item {
35 u32 major, minor;
36 short type;
37 short access;
38 struct list_head list;
4efd1a1b 39 struct rcu_head rcu;
08ce5f16
SH
40};
41
42struct dev_cgroup {
43 struct cgroup_subsys_state css;
44 struct list_head whitelist;
66b8ef67 45 bool deny_all;
08ce5f16
SH
46};
47
b66862f7
PE
48static inline struct dev_cgroup *css_to_devcgroup(struct cgroup_subsys_state *s)
49{
50 return container_of(s, struct dev_cgroup, css);
51}
52
08ce5f16
SH
53static inline struct dev_cgroup *cgroup_to_devcgroup(struct cgroup *cgroup)
54{
b66862f7 55 return css_to_devcgroup(cgroup_subsys_state(cgroup, devices_subsys_id));
08ce5f16
SH
56}
57
f92523e3
PM
58static inline struct dev_cgroup *task_devcgroup(struct task_struct *task)
59{
60 return css_to_devcgroup(task_subsys_state(task, devices_subsys_id));
61}
62
08ce5f16
SH
63struct cgroup_subsys devices_subsys;
64
761b3ef5
LZ
65static int devcgroup_can_attach(struct cgroup *new_cgrp,
66 struct cgroup_taskset *set)
08ce5f16 67{
2f7ee569 68 struct task_struct *task = cgroup_taskset_first(set);
08ce5f16 69
2f7ee569
TH
70 if (current != task && !capable(CAP_SYS_ADMIN))
71 return -EPERM;
08ce5f16
SH
72 return 0;
73}
74
75/*
b4046f00 76 * called under devcgroup_mutex
08ce5f16
SH
77 */
78static int dev_whitelist_copy(struct list_head *dest, struct list_head *orig)
79{
80 struct dev_whitelist_item *wh, *tmp, *new;
81
82 list_for_each_entry(wh, orig, list) {
2cdc7241 83 new = kmemdup(wh, sizeof(*wh), GFP_KERNEL);
08ce5f16
SH
84 if (!new)
85 goto free_and_exit;
08ce5f16
SH
86 list_add_tail(&new->list, dest);
87 }
88
89 return 0;
90
91free_and_exit:
92 list_for_each_entry_safe(wh, tmp, dest, list) {
93 list_del(&wh->list);
94 kfree(wh);
95 }
96 return -ENOMEM;
97}
98
99/* Stupid prototype - don't bother combining existing entries */
100/*
b4046f00 101 * called under devcgroup_mutex
08ce5f16
SH
102 */
103static int dev_whitelist_add(struct dev_cgroup *dev_cgroup,
104 struct dev_whitelist_item *wh)
105{
d1ee2971 106 struct dev_whitelist_item *whcopy, *walk;
08ce5f16 107
2cdc7241 108 whcopy = kmemdup(wh, sizeof(*wh), GFP_KERNEL);
08ce5f16
SH
109 if (!whcopy)
110 return -ENOMEM;
111
d1ee2971
PE
112 list_for_each_entry(walk, &dev_cgroup->whitelist, list) {
113 if (walk->type != wh->type)
114 continue;
115 if (walk->major != wh->major)
116 continue;
117 if (walk->minor != wh->minor)
118 continue;
119
120 walk->access |= wh->access;
121 kfree(whcopy);
122 whcopy = NULL;
123 }
124
125 if (whcopy != NULL)
4efd1a1b 126 list_add_tail_rcu(&whcopy->list, &dev_cgroup->whitelist);
08ce5f16
SH
127 return 0;
128}
129
130/*
b4046f00 131 * called under devcgroup_mutex
08ce5f16
SH
132 */
133static void dev_whitelist_rm(struct dev_cgroup *dev_cgroup,
134 struct dev_whitelist_item *wh)
135{
136 struct dev_whitelist_item *walk, *tmp;
137
08ce5f16
SH
138 list_for_each_entry_safe(walk, tmp, &dev_cgroup->whitelist, list) {
139 if (walk->type == DEV_ALL)
140 goto remove;
141 if (walk->type != wh->type)
142 continue;
143 if (walk->major != ~0 && walk->major != wh->major)
144 continue;
145 if (walk->minor != ~0 && walk->minor != wh->minor)
146 continue;
147
148remove:
149 walk->access &= ~wh->access;
150 if (!walk->access) {
4efd1a1b 151 list_del_rcu(&walk->list);
6034f7e6 152 kfree_rcu(walk, rcu);
08ce5f16
SH
153 }
154 }
08ce5f16
SH
155}
156
868539a3
AR
157/**
158 * dev_whitelist_clean - frees all entries of the whitelist
159 * @dev_cgroup: dev_cgroup with the whitelist to be cleaned
160 *
161 * called under devcgroup_mutex
162 */
163static void dev_whitelist_clean(struct dev_cgroup *dev_cgroup)
164{
165 struct dev_whitelist_item *wh, *tmp;
166
167 list_for_each_entry_safe(wh, tmp, &dev_cgroup->whitelist, list) {
168 list_del(&wh->list);
169 kfree(wh);
170 }
171}
172
08ce5f16
SH
173/*
174 * called from kernel/cgroup.c with cgroup_lock() held.
175 */
761b3ef5 176static struct cgroup_subsys_state *devcgroup_create(struct cgroup *cgroup)
08ce5f16
SH
177{
178 struct dev_cgroup *dev_cgroup, *parent_dev_cgroup;
179 struct cgroup *parent_cgroup;
180 int ret;
181
182 dev_cgroup = kzalloc(sizeof(*dev_cgroup), GFP_KERNEL);
183 if (!dev_cgroup)
184 return ERR_PTR(-ENOMEM);
185 INIT_LIST_HEAD(&dev_cgroup->whitelist);
186 parent_cgroup = cgroup->parent;
187
188 if (parent_cgroup == NULL) {
189 struct dev_whitelist_item *wh;
190 wh = kmalloc(sizeof(*wh), GFP_KERNEL);
191 if (!wh) {
192 kfree(dev_cgroup);
193 return ERR_PTR(-ENOMEM);
194 }
195 wh->minor = wh->major = ~0;
196 wh->type = DEV_ALL;
7759fc9d 197 wh->access = ACC_MASK;
66b8ef67 198 dev_cgroup->deny_all = false;
08ce5f16
SH
199 list_add(&wh->list, &dev_cgroup->whitelist);
200 } else {
201 parent_dev_cgroup = cgroup_to_devcgroup(parent_cgroup);
b4046f00 202 mutex_lock(&devcgroup_mutex);
08ce5f16
SH
203 ret = dev_whitelist_copy(&dev_cgroup->whitelist,
204 &parent_dev_cgroup->whitelist);
66b8ef67 205 dev_cgroup->deny_all = parent_dev_cgroup->deny_all;
b4046f00 206 mutex_unlock(&devcgroup_mutex);
08ce5f16
SH
207 if (ret) {
208 kfree(dev_cgroup);
209 return ERR_PTR(ret);
210 }
211 }
212
08ce5f16
SH
213 return &dev_cgroup->css;
214}
215
761b3ef5 216static void devcgroup_destroy(struct cgroup *cgroup)
08ce5f16
SH
217{
218 struct dev_cgroup *dev_cgroup;
08ce5f16
SH
219
220 dev_cgroup = cgroup_to_devcgroup(cgroup);
868539a3 221 dev_whitelist_clean(dev_cgroup);
08ce5f16
SH
222 kfree(dev_cgroup);
223}
224
225#define DEVCG_ALLOW 1
226#define DEVCG_DENY 2
29486df3
SH
227#define DEVCG_LIST 3
228
17d213f8 229#define MAJMINLEN 13
29486df3 230#define ACCLEN 4
08ce5f16
SH
231
232static void set_access(char *acc, short access)
233{
234 int idx = 0;
29486df3 235 memset(acc, 0, ACCLEN);
08ce5f16
SH
236 if (access & ACC_READ)
237 acc[idx++] = 'r';
238 if (access & ACC_WRITE)
239 acc[idx++] = 'w';
240 if (access & ACC_MKNOD)
241 acc[idx++] = 'm';
242}
243
244static char type_to_char(short type)
245{
246 if (type == DEV_ALL)
247 return 'a';
248 if (type == DEV_CHAR)
249 return 'c';
250 if (type == DEV_BLOCK)
251 return 'b';
252 return 'X';
253}
254
29486df3 255static void set_majmin(char *str, unsigned m)
08ce5f16 256{
08ce5f16 257 if (m == ~0)
7759fc9d 258 strcpy(str, "*");
08ce5f16 259 else
7759fc9d 260 sprintf(str, "%u", m);
08ce5f16
SH
261}
262
29486df3
SH
263static int devcgroup_seq_read(struct cgroup *cgroup, struct cftype *cft,
264 struct seq_file *m)
08ce5f16 265{
29486df3 266 struct dev_cgroup *devcgroup = cgroup_to_devcgroup(cgroup);
08ce5f16 267 struct dev_whitelist_item *wh;
29486df3 268 char maj[MAJMINLEN], min[MAJMINLEN], acc[ACCLEN];
08ce5f16 269
4efd1a1b
PE
270 rcu_read_lock();
271 list_for_each_entry_rcu(wh, &devcgroup->whitelist, list) {
08ce5f16 272 set_access(acc, wh->access);
29486df3
SH
273 set_majmin(maj, wh->major);
274 set_majmin(min, wh->minor);
275 seq_printf(m, "%c %s:%s %s\n", type_to_char(wh->type),
276 maj, min, acc);
08ce5f16 277 }
4efd1a1b 278 rcu_read_unlock();
08ce5f16 279
29486df3 280 return 0;
08ce5f16
SH
281}
282
283/*
284 * may_access_whitelist:
285 * does the access granted to dev_cgroup c contain the access
286 * requested in whitelist item refwh.
287 * return 1 if yes, 0 if no.
b4046f00 288 * call with devcgroup_mutex held
08ce5f16
SH
289 */
290static int may_access_whitelist(struct dev_cgroup *c,
291 struct dev_whitelist_item *refwh)
292{
293 struct dev_whitelist_item *whitem;
294
295 list_for_each_entry(whitem, &c->whitelist, list) {
296 if (whitem->type & DEV_ALL)
297 return 1;
298 if ((refwh->type & DEV_BLOCK) && !(whitem->type & DEV_BLOCK))
299 continue;
300 if ((refwh->type & DEV_CHAR) && !(whitem->type & DEV_CHAR))
301 continue;
302 if (whitem->major != ~0 && whitem->major != refwh->major)
303 continue;
304 if (whitem->minor != ~0 && whitem->minor != refwh->minor)
305 continue;
ec229e83 306 if (refwh->access & (~whitem->access))
08ce5f16
SH
307 continue;
308 return 1;
309 }
310 return 0;
311}
312
313/*
314 * parent_has_perm:
315 * when adding a new allow rule to a device whitelist, the rule
316 * must be allowed in the parent device
317 */
f92523e3 318static int parent_has_perm(struct dev_cgroup *childcg,
08ce5f16
SH
319 struct dev_whitelist_item *wh)
320{
f92523e3 321 struct cgroup *pcg = childcg->css.cgroup->parent;
08ce5f16 322 struct dev_cgroup *parent;
08ce5f16
SH
323
324 if (!pcg)
325 return 1;
326 parent = cgroup_to_devcgroup(pcg);
47c59803 327 return may_access_whitelist(parent, wh);
08ce5f16
SH
328}
329
330/*
331 * Modify the whitelist using allow/deny rules.
332 * CAP_SYS_ADMIN is needed for this. It's at least separate from CAP_MKNOD
333 * so we can give a container CAP_MKNOD to let it create devices but not
334 * modify the whitelist.
335 * It seems likely we'll want to add a CAP_CONTAINER capability to allow
336 * us to also grant CAP_SYS_ADMIN to containers without giving away the
337 * device whitelist controls, but for now we'll stick with CAP_SYS_ADMIN
338 *
339 * Taking rules away is always allowed (given CAP_SYS_ADMIN). Granting
340 * new access is only allowed if you're in the top-level cgroup, or your
341 * parent cgroup has the access you're asking for.
342 */
f92523e3
PM
343static int devcgroup_update_access(struct dev_cgroup *devcgroup,
344 int filetype, const char *buffer)
08ce5f16 345{
f92523e3 346 const char *b;
7759fc9d 347 char *endp;
c012a54a 348 int count;
08ce5f16
SH
349 struct dev_whitelist_item wh;
350
351 if (!capable(CAP_SYS_ADMIN))
352 return -EPERM;
353
08ce5f16
SH
354 memset(&wh, 0, sizeof(wh));
355 b = buffer;
356
357 switch (*b) {
358 case 'a':
359 wh.type = DEV_ALL;
360 wh.access = ACC_MASK;
d823f6bf
LZ
361 wh.major = ~0;
362 wh.minor = ~0;
08ce5f16
SH
363 goto handle;
364 case 'b':
365 wh.type = DEV_BLOCK;
366 break;
367 case 'c':
368 wh.type = DEV_CHAR;
369 break;
370 default:
f92523e3 371 return -EINVAL;
08ce5f16
SH
372 }
373 b++;
f92523e3
PM
374 if (!isspace(*b))
375 return -EINVAL;
08ce5f16
SH
376 b++;
377 if (*b == '*') {
378 wh.major = ~0;
379 b++;
380 } else if (isdigit(*b)) {
7759fc9d
LZ
381 wh.major = simple_strtoul(b, &endp, 10);
382 b = endp;
08ce5f16 383 } else {
f92523e3 384 return -EINVAL;
08ce5f16 385 }
f92523e3
PM
386 if (*b != ':')
387 return -EINVAL;
08ce5f16
SH
388 b++;
389
390 /* read minor */
391 if (*b == '*') {
392 wh.minor = ~0;
393 b++;
394 } else if (isdigit(*b)) {
7759fc9d
LZ
395 wh.minor = simple_strtoul(b, &endp, 10);
396 b = endp;
08ce5f16 397 } else {
f92523e3 398 return -EINVAL;
08ce5f16 399 }
f92523e3
PM
400 if (!isspace(*b))
401 return -EINVAL;
08ce5f16
SH
402 for (b++, count = 0; count < 3; count++, b++) {
403 switch (*b) {
404 case 'r':
405 wh.access |= ACC_READ;
406 break;
407 case 'w':
408 wh.access |= ACC_WRITE;
409 break;
410 case 'm':
411 wh.access |= ACC_MKNOD;
412 break;
413 case '\n':
414 case '\0':
415 count = 3;
416 break;
417 default:
f92523e3 418 return -EINVAL;
08ce5f16
SH
419 }
420 }
421
422handle:
08ce5f16
SH
423 switch (filetype) {
424 case DEVCG_ALLOW:
f92523e3
PM
425 if (!parent_has_perm(devcgroup, &wh))
426 return -EPERM;
66b8ef67 427 devcgroup->deny_all = false;
f92523e3 428 return dev_whitelist_add(devcgroup, &wh);
08ce5f16
SH
429 case DEVCG_DENY:
430 dev_whitelist_rm(devcgroup, &wh);
66b8ef67 431 devcgroup->deny_all = true;
08ce5f16
SH
432 break;
433 default:
f92523e3 434 return -EINVAL;
08ce5f16 435 }
f92523e3
PM
436 return 0;
437}
08ce5f16 438
f92523e3
PM
439static int devcgroup_access_write(struct cgroup *cgrp, struct cftype *cft,
440 const char *buffer)
441{
442 int retval;
b4046f00
LZ
443
444 mutex_lock(&devcgroup_mutex);
f92523e3
PM
445 retval = devcgroup_update_access(cgroup_to_devcgroup(cgrp),
446 cft->private, buffer);
b4046f00 447 mutex_unlock(&devcgroup_mutex);
08ce5f16
SH
448 return retval;
449}
450
451static struct cftype dev_cgroup_files[] = {
452 {
453 .name = "allow",
f92523e3 454 .write_string = devcgroup_access_write,
08ce5f16
SH
455 .private = DEVCG_ALLOW,
456 },
457 {
458 .name = "deny",
f92523e3 459 .write_string = devcgroup_access_write,
08ce5f16
SH
460 .private = DEVCG_DENY,
461 },
29486df3
SH
462 {
463 .name = "list",
464 .read_seq_string = devcgroup_seq_read,
465 .private = DEVCG_LIST,
466 },
4baf6e33 467 { } /* terminate */
08ce5f16
SH
468};
469
08ce5f16
SH
470struct cgroup_subsys devices_subsys = {
471 .name = "devices",
472 .can_attach = devcgroup_can_attach,
473 .create = devcgroup_create,
c5b60b5e 474 .destroy = devcgroup_destroy,
08ce5f16 475 .subsys_id = devices_subsys_id,
4baf6e33 476 .base_cftypes = dev_cgroup_files,
8c7f6edb
TH
477
478 /*
479 * While devices cgroup has the rudimentary hierarchy support which
480 * checks the parent's restriction, it doesn't properly propagates
481 * config changes in ancestors to their descendents. A child
482 * should only be allowed to add more restrictions to the parent's
483 * configuration. Fix it and remove the following.
484 */
485 .broken_hierarchy = true,
08ce5f16
SH
486};
487
482e0cd3 488int __devcgroup_inode_permission(struct inode *inode, int mask)
08ce5f16 489{
08ce5f16
SH
490 struct dev_cgroup *dev_cgroup;
491 struct dev_whitelist_item *wh;
492
4efd1a1b 493 rcu_read_lock();
36fd71d2
LZ
494
495 dev_cgroup = task_devcgroup(current);
496
4efd1a1b 497 list_for_each_entry_rcu(wh, &dev_cgroup->whitelist, list) {
08ce5f16 498 if (wh->type & DEV_ALL)
cd500819 499 goto found;
08ce5f16
SH
500 if ((wh->type & DEV_BLOCK) && !S_ISBLK(inode->i_mode))
501 continue;
502 if ((wh->type & DEV_CHAR) && !S_ISCHR(inode->i_mode))
503 continue;
504 if (wh->major != ~0 && wh->major != imajor(inode))
505 continue;
506 if (wh->minor != ~0 && wh->minor != iminor(inode))
507 continue;
cd500819 508
08ce5f16
SH
509 if ((mask & MAY_WRITE) && !(wh->access & ACC_WRITE))
510 continue;
511 if ((mask & MAY_READ) && !(wh->access & ACC_READ))
512 continue;
cd500819 513found:
4efd1a1b 514 rcu_read_unlock();
08ce5f16
SH
515 return 0;
516 }
36fd71d2 517
4efd1a1b 518 rcu_read_unlock();
08ce5f16
SH
519
520 return -EPERM;
521}
522
523int devcgroup_inode_mknod(int mode, dev_t dev)
524{
08ce5f16
SH
525 struct dev_cgroup *dev_cgroup;
526 struct dev_whitelist_item *wh;
527
0b82ac37
SH
528 if (!S_ISBLK(mode) && !S_ISCHR(mode))
529 return 0;
530
4efd1a1b 531 rcu_read_lock();
36fd71d2
LZ
532
533 dev_cgroup = task_devcgroup(current);
534
116e0575 535 list_for_each_entry_rcu(wh, &dev_cgroup->whitelist, list) {
08ce5f16 536 if (wh->type & DEV_ALL)
cd500819 537 goto found;
08ce5f16
SH
538 if ((wh->type & DEV_BLOCK) && !S_ISBLK(mode))
539 continue;
540 if ((wh->type & DEV_CHAR) && !S_ISCHR(mode))
541 continue;
542 if (wh->major != ~0 && wh->major != MAJOR(dev))
543 continue;
544 if (wh->minor != ~0 && wh->minor != MINOR(dev))
545 continue;
cd500819 546
08ce5f16
SH
547 if (!(wh->access & ACC_MKNOD))
548 continue;
cd500819 549found:
4efd1a1b 550 rcu_read_unlock();
08ce5f16
SH
551 return 0;
552 }
36fd71d2 553
4efd1a1b 554 rcu_read_unlock();
36fd71d2 555
08ce5f16
SH
556 return -EPERM;
557}