device_cgroup: stop using simple_strtoul()
[linux-2.6-block.git] / security / device_cgroup.c
CommitLineData
08ce5f16 1/*
47c59803 2 * device_cgroup.c - device cgroup subsystem
08ce5f16
SH
3 *
4 * Copyright 2007 IBM Corp
5 */
6
7#include <linux/device_cgroup.h>
8#include <linux/cgroup.h>
9#include <linux/ctype.h>
10#include <linux/list.h>
11#include <linux/uaccess.h>
29486df3 12#include <linux/seq_file.h>
5a0e3ad6 13#include <linux/slab.h>
47c59803 14#include <linux/rcupdate.h>
b4046f00 15#include <linux/mutex.h>
08ce5f16
SH
16
17#define ACC_MKNOD 1
18#define ACC_READ 2
19#define ACC_WRITE 4
20#define ACC_MASK (ACC_MKNOD | ACC_READ | ACC_WRITE)
21
22#define DEV_BLOCK 1
23#define DEV_CHAR 2
24#define DEV_ALL 4 /* this represents all devices */
25
b4046f00
LZ
26static DEFINE_MUTEX(devcgroup_mutex);
27
08ce5f16 28/*
db9aeca9 29 * exception list locking rules:
b4046f00 30 * hold devcgroup_mutex for update/read.
47c59803 31 * hold rcu_read_lock() for read.
08ce5f16
SH
32 */
33
db9aeca9 34struct dev_exception_item {
08ce5f16
SH
35 u32 major, minor;
36 short type;
37 short access;
38 struct list_head list;
4efd1a1b 39 struct rcu_head rcu;
08ce5f16
SH
40};
41
42struct dev_cgroup {
43 struct cgroup_subsys_state css;
db9aeca9 44 struct list_head exceptions;
5b7aa7d5
AR
45 enum {
46 DEVCG_DEFAULT_ALLOW,
47 DEVCG_DEFAULT_DENY,
48 } behavior;
08ce5f16
SH
49};
50
b66862f7
PE
51static inline struct dev_cgroup *css_to_devcgroup(struct cgroup_subsys_state *s)
52{
53 return container_of(s, struct dev_cgroup, css);
54}
55
08ce5f16
SH
56static inline struct dev_cgroup *cgroup_to_devcgroup(struct cgroup *cgroup)
57{
b66862f7 58 return css_to_devcgroup(cgroup_subsys_state(cgroup, devices_subsys_id));
08ce5f16
SH
59}
60
f92523e3
PM
61static inline struct dev_cgroup *task_devcgroup(struct task_struct *task)
62{
63 return css_to_devcgroup(task_subsys_state(task, devices_subsys_id));
64}
65
08ce5f16
SH
66struct cgroup_subsys devices_subsys;
67
761b3ef5
LZ
68static int devcgroup_can_attach(struct cgroup *new_cgrp,
69 struct cgroup_taskset *set)
08ce5f16 70{
2f7ee569 71 struct task_struct *task = cgroup_taskset_first(set);
08ce5f16 72
2f7ee569
TH
73 if (current != task && !capable(CAP_SYS_ADMIN))
74 return -EPERM;
08ce5f16
SH
75 return 0;
76}
77
78/*
b4046f00 79 * called under devcgroup_mutex
08ce5f16 80 */
db9aeca9 81static int dev_exceptions_copy(struct list_head *dest, struct list_head *orig)
08ce5f16 82{
db9aeca9 83 struct dev_exception_item *ex, *tmp, *new;
08ce5f16 84
db9aeca9
AR
85 list_for_each_entry(ex, orig, list) {
86 new = kmemdup(ex, sizeof(*ex), GFP_KERNEL);
08ce5f16
SH
87 if (!new)
88 goto free_and_exit;
08ce5f16
SH
89 list_add_tail(&new->list, dest);
90 }
91
92 return 0;
93
94free_and_exit:
db9aeca9
AR
95 list_for_each_entry_safe(ex, tmp, dest, list) {
96 list_del(&ex->list);
97 kfree(ex);
08ce5f16
SH
98 }
99 return -ENOMEM;
100}
101
08ce5f16 102/*
b4046f00 103 * called under devcgroup_mutex
08ce5f16 104 */
db9aeca9
AR
105static int dev_exception_add(struct dev_cgroup *dev_cgroup,
106 struct dev_exception_item *ex)
08ce5f16 107{
db9aeca9 108 struct dev_exception_item *excopy, *walk;
08ce5f16 109
db9aeca9
AR
110 excopy = kmemdup(ex, sizeof(*ex), GFP_KERNEL);
111 if (!excopy)
08ce5f16
SH
112 return -ENOMEM;
113
db9aeca9
AR
114 list_for_each_entry(walk, &dev_cgroup->exceptions, list) {
115 if (walk->type != ex->type)
d1ee2971 116 continue;
db9aeca9 117 if (walk->major != ex->major)
d1ee2971 118 continue;
db9aeca9 119 if (walk->minor != ex->minor)
d1ee2971
PE
120 continue;
121
db9aeca9
AR
122 walk->access |= ex->access;
123 kfree(excopy);
124 excopy = NULL;
d1ee2971
PE
125 }
126
db9aeca9
AR
127 if (excopy != NULL)
128 list_add_tail_rcu(&excopy->list, &dev_cgroup->exceptions);
08ce5f16
SH
129 return 0;
130}
131
132/*
b4046f00 133 * called under devcgroup_mutex
08ce5f16 134 */
db9aeca9
AR
135static void dev_exception_rm(struct dev_cgroup *dev_cgroup,
136 struct dev_exception_item *ex)
08ce5f16 137{
db9aeca9 138 struct dev_exception_item *walk, *tmp;
08ce5f16 139
db9aeca9
AR
140 list_for_each_entry_safe(walk, tmp, &dev_cgroup->exceptions, list) {
141 if (walk->type != ex->type)
08ce5f16 142 continue;
db9aeca9 143 if (walk->major != ex->major)
08ce5f16 144 continue;
db9aeca9 145 if (walk->minor != ex->minor)
08ce5f16
SH
146 continue;
147
db9aeca9 148 walk->access &= ~ex->access;
08ce5f16 149 if (!walk->access) {
4efd1a1b 150 list_del_rcu(&walk->list);
6034f7e6 151 kfree_rcu(walk, rcu);
08ce5f16
SH
152 }
153 }
08ce5f16
SH
154}
155
868539a3 156/**
db9aeca9
AR
157 * dev_exception_clean - frees all entries of the exception list
158 * @dev_cgroup: dev_cgroup with the exception list to be cleaned
868539a3
AR
159 *
160 * called under devcgroup_mutex
161 */
db9aeca9 162static void dev_exception_clean(struct dev_cgroup *dev_cgroup)
868539a3 163{
db9aeca9 164 struct dev_exception_item *ex, *tmp;
868539a3 165
db9aeca9
AR
166 list_for_each_entry_safe(ex, tmp, &dev_cgroup->exceptions, list) {
167 list_del(&ex->list);
168 kfree(ex);
868539a3
AR
169 }
170}
171
08ce5f16
SH
172/*
173 * called from kernel/cgroup.c with cgroup_lock() held.
174 */
761b3ef5 175static struct cgroup_subsys_state *devcgroup_create(struct cgroup *cgroup)
08ce5f16
SH
176{
177 struct dev_cgroup *dev_cgroup, *parent_dev_cgroup;
178 struct cgroup *parent_cgroup;
179 int ret;
180
181 dev_cgroup = kzalloc(sizeof(*dev_cgroup), GFP_KERNEL);
182 if (!dev_cgroup)
183 return ERR_PTR(-ENOMEM);
db9aeca9 184 INIT_LIST_HEAD(&dev_cgroup->exceptions);
08ce5f16
SH
185 parent_cgroup = cgroup->parent;
186
ad676077 187 if (parent_cgroup == NULL)
5b7aa7d5 188 dev_cgroup->behavior = DEVCG_DEFAULT_ALLOW;
ad676077 189 else {
08ce5f16 190 parent_dev_cgroup = cgroup_to_devcgroup(parent_cgroup);
b4046f00 191 mutex_lock(&devcgroup_mutex);
db9aeca9
AR
192 ret = dev_exceptions_copy(&dev_cgroup->exceptions,
193 &parent_dev_cgroup->exceptions);
5b7aa7d5 194 dev_cgroup->behavior = parent_dev_cgroup->behavior;
b4046f00 195 mutex_unlock(&devcgroup_mutex);
08ce5f16
SH
196 if (ret) {
197 kfree(dev_cgroup);
198 return ERR_PTR(ret);
199 }
200 }
201
08ce5f16
SH
202 return &dev_cgroup->css;
203}
204
761b3ef5 205static void devcgroup_destroy(struct cgroup *cgroup)
08ce5f16
SH
206{
207 struct dev_cgroup *dev_cgroup;
08ce5f16
SH
208
209 dev_cgroup = cgroup_to_devcgroup(cgroup);
db9aeca9 210 dev_exception_clean(dev_cgroup);
08ce5f16
SH
211 kfree(dev_cgroup);
212}
213
214#define DEVCG_ALLOW 1
215#define DEVCG_DENY 2
29486df3
SH
216#define DEVCG_LIST 3
217
17d213f8 218#define MAJMINLEN 13
29486df3 219#define ACCLEN 4
08ce5f16
SH
220
221static void set_access(char *acc, short access)
222{
223 int idx = 0;
29486df3 224 memset(acc, 0, ACCLEN);
08ce5f16
SH
225 if (access & ACC_READ)
226 acc[idx++] = 'r';
227 if (access & ACC_WRITE)
228 acc[idx++] = 'w';
229 if (access & ACC_MKNOD)
230 acc[idx++] = 'm';
231}
232
233static char type_to_char(short type)
234{
235 if (type == DEV_ALL)
236 return 'a';
237 if (type == DEV_CHAR)
238 return 'c';
239 if (type == DEV_BLOCK)
240 return 'b';
241 return 'X';
242}
243
29486df3 244static void set_majmin(char *str, unsigned m)
08ce5f16 245{
08ce5f16 246 if (m == ~0)
7759fc9d 247 strcpy(str, "*");
08ce5f16 248 else
7759fc9d 249 sprintf(str, "%u", m);
08ce5f16
SH
250}
251
29486df3
SH
252static int devcgroup_seq_read(struct cgroup *cgroup, struct cftype *cft,
253 struct seq_file *m)
08ce5f16 254{
29486df3 255 struct dev_cgroup *devcgroup = cgroup_to_devcgroup(cgroup);
db9aeca9 256 struct dev_exception_item *ex;
29486df3 257 char maj[MAJMINLEN], min[MAJMINLEN], acc[ACCLEN];
08ce5f16 258
4efd1a1b 259 rcu_read_lock();
ad676077
AR
260 /*
261 * To preserve the compatibility:
262 * - Only show the "all devices" when the default policy is to allow
263 * - List the exceptions in case the default policy is to deny
264 * This way, the file remains as a "whitelist of devices"
265 */
5b7aa7d5 266 if (devcgroup->behavior == DEVCG_DEFAULT_ALLOW) {
ad676077
AR
267 set_access(acc, ACC_MASK);
268 set_majmin(maj, ~0);
269 set_majmin(min, ~0);
270 seq_printf(m, "%c %s:%s %s\n", type_to_char(DEV_ALL),
29486df3 271 maj, min, acc);
ad676077 272 } else {
db9aeca9
AR
273 list_for_each_entry_rcu(ex, &devcgroup->exceptions, list) {
274 set_access(acc, ex->access);
275 set_majmin(maj, ex->major);
276 set_majmin(min, ex->minor);
277 seq_printf(m, "%c %s:%s %s\n", type_to_char(ex->type),
ad676077
AR
278 maj, min, acc);
279 }
08ce5f16 280 }
4efd1a1b 281 rcu_read_unlock();
08ce5f16 282
29486df3 283 return 0;
08ce5f16
SH
284}
285
ad676077 286/**
db9aeca9
AR
287 * may_access - verifies if a new exception is part of what is allowed
288 * by a dev cgroup based on the default policy +
289 * exceptions. This is used to make sure a child cgroup
290 * won't have more privileges than its parent or to
291 * verify if a certain access is allowed.
ad676077 292 * @dev_cgroup: dev cgroup to be tested against
db9aeca9 293 * @refex: new exception
08ce5f16 294 */
db9aeca9
AR
295static int may_access(struct dev_cgroup *dev_cgroup,
296 struct dev_exception_item *refex)
08ce5f16 297{
db9aeca9 298 struct dev_exception_item *ex;
ad676077 299 bool match = false;
08ce5f16 300
db9aeca9
AR
301 list_for_each_entry(ex, &dev_cgroup->exceptions, list) {
302 if ((refex->type & DEV_BLOCK) && !(ex->type & DEV_BLOCK))
08ce5f16 303 continue;
db9aeca9 304 if ((refex->type & DEV_CHAR) && !(ex->type & DEV_CHAR))
08ce5f16 305 continue;
db9aeca9 306 if (ex->major != ~0 && ex->major != refex->major)
08ce5f16 307 continue;
db9aeca9 308 if (ex->minor != ~0 && ex->minor != refex->minor)
08ce5f16 309 continue;
db9aeca9 310 if (refex->access & (~ex->access))
08ce5f16 311 continue;
ad676077
AR
312 match = true;
313 break;
08ce5f16 314 }
ad676077
AR
315
316 /*
db9aeca9 317 * In two cases we'll consider this new exception valid:
ad676077 318 * - the dev cgroup has its default policy to allow + exception list:
db9aeca9 319 * the new exception should *not* match any of the exceptions
5b7aa7d5 320 * (behavior == DEVCG_DEFAULT_ALLOW, !match)
ad676077 321 * - the dev cgroup has its default policy to deny + exception list:
db9aeca9 322 * the new exception *should* match the exceptions
5b7aa7d5 323 * (behavior == DEVCG_DEFAULT_DENY, match)
ad676077 324 */
5b7aa7d5 325 if ((dev_cgroup->behavior == DEVCG_DEFAULT_DENY) == match)
ad676077 326 return 1;
08ce5f16
SH
327 return 0;
328}
329
330/*
331 * parent_has_perm:
db9aeca9 332 * when adding a new allow rule to a device exception list, the rule
08ce5f16
SH
333 * must be allowed in the parent device
334 */
f92523e3 335static int parent_has_perm(struct dev_cgroup *childcg,
db9aeca9 336 struct dev_exception_item *ex)
08ce5f16 337{
f92523e3 338 struct cgroup *pcg = childcg->css.cgroup->parent;
08ce5f16 339 struct dev_cgroup *parent;
08ce5f16
SH
340
341 if (!pcg)
342 return 1;
343 parent = cgroup_to_devcgroup(pcg);
db9aeca9 344 return may_access(parent, ex);
08ce5f16
SH
345}
346
347/*
db9aeca9 348 * Modify the exception list using allow/deny rules.
08ce5f16
SH
349 * CAP_SYS_ADMIN is needed for this. It's at least separate from CAP_MKNOD
350 * so we can give a container CAP_MKNOD to let it create devices but not
db9aeca9 351 * modify the exception list.
08ce5f16
SH
352 * It seems likely we'll want to add a CAP_CONTAINER capability to allow
353 * us to also grant CAP_SYS_ADMIN to containers without giving away the
db9aeca9 354 * device exception list controls, but for now we'll stick with CAP_SYS_ADMIN
08ce5f16
SH
355 *
356 * Taking rules away is always allowed (given CAP_SYS_ADMIN). Granting
357 * new access is only allowed if you're in the top-level cgroup, or your
358 * parent cgroup has the access you're asking for.
359 */
f92523e3
PM
360static int devcgroup_update_access(struct dev_cgroup *devcgroup,
361 int filetype, const char *buffer)
08ce5f16 362{
f92523e3 363 const char *b;
26fd8405
AR
364 char temp[12]; /* 11 + 1 characters needed for a u32 */
365 int count, rc;
db9aeca9 366 struct dev_exception_item ex;
08ce5f16
SH
367
368 if (!capable(CAP_SYS_ADMIN))
369 return -EPERM;
370
db9aeca9 371 memset(&ex, 0, sizeof(ex));
08ce5f16
SH
372 b = buffer;
373
374 switch (*b) {
375 case 'a':
ad676077
AR
376 switch (filetype) {
377 case DEVCG_ALLOW:
db9aeca9 378 if (!parent_has_perm(devcgroup, &ex))
ad676077 379 return -EPERM;
db9aeca9 380 dev_exception_clean(devcgroup);
5b7aa7d5 381 devcgroup->behavior = DEVCG_DEFAULT_ALLOW;
ad676077
AR
382 break;
383 case DEVCG_DENY:
db9aeca9 384 dev_exception_clean(devcgroup);
5b7aa7d5 385 devcgroup->behavior = DEVCG_DEFAULT_DENY;
ad676077
AR
386 break;
387 default:
388 return -EINVAL;
389 }
390 return 0;
08ce5f16 391 case 'b':
db9aeca9 392 ex.type = DEV_BLOCK;
08ce5f16
SH
393 break;
394 case 'c':
db9aeca9 395 ex.type = DEV_CHAR;
08ce5f16
SH
396 break;
397 default:
f92523e3 398 return -EINVAL;
08ce5f16
SH
399 }
400 b++;
f92523e3
PM
401 if (!isspace(*b))
402 return -EINVAL;
08ce5f16
SH
403 b++;
404 if (*b == '*') {
db9aeca9 405 ex.major = ~0;
08ce5f16
SH
406 b++;
407 } else if (isdigit(*b)) {
26fd8405
AR
408 memset(temp, 0, sizeof(temp));
409 for (count = 0; count < sizeof(temp) - 1; count++) {
410 temp[count] = *b;
411 b++;
412 if (!isdigit(*b))
413 break;
414 }
415 rc = kstrtou32(temp, 10, &ex.major);
416 if (rc)
417 return -EINVAL;
08ce5f16 418 } else {
f92523e3 419 return -EINVAL;
08ce5f16 420 }
f92523e3
PM
421 if (*b != ':')
422 return -EINVAL;
08ce5f16
SH
423 b++;
424
425 /* read minor */
426 if (*b == '*') {
db9aeca9 427 ex.minor = ~0;
08ce5f16
SH
428 b++;
429 } else if (isdigit(*b)) {
26fd8405
AR
430 memset(temp, 0, sizeof(temp));
431 for (count = 0; count < sizeof(temp) - 1; count++) {
432 temp[count] = *b;
433 b++;
434 if (!isdigit(*b))
435 break;
436 }
437 rc = kstrtou32(temp, 10, &ex.minor);
438 if (rc)
439 return -EINVAL;
08ce5f16 440 } else {
f92523e3 441 return -EINVAL;
08ce5f16 442 }
f92523e3
PM
443 if (!isspace(*b))
444 return -EINVAL;
08ce5f16
SH
445 for (b++, count = 0; count < 3; count++, b++) {
446 switch (*b) {
447 case 'r':
db9aeca9 448 ex.access |= ACC_READ;
08ce5f16
SH
449 break;
450 case 'w':
db9aeca9 451 ex.access |= ACC_WRITE;
08ce5f16
SH
452 break;
453 case 'm':
db9aeca9 454 ex.access |= ACC_MKNOD;
08ce5f16
SH
455 break;
456 case '\n':
457 case '\0':
458 count = 3;
459 break;
460 default:
f92523e3 461 return -EINVAL;
08ce5f16
SH
462 }
463 }
464
08ce5f16
SH
465 switch (filetype) {
466 case DEVCG_ALLOW:
db9aeca9 467 if (!parent_has_perm(devcgroup, &ex))
f92523e3 468 return -EPERM;
ad676077
AR
469 /*
470 * If the default policy is to allow by default, try to remove
471 * an matching exception instead. And be silent about it: we
472 * don't want to break compatibility
473 */
5b7aa7d5 474 if (devcgroup->behavior == DEVCG_DEFAULT_ALLOW) {
db9aeca9 475 dev_exception_rm(devcgroup, &ex);
ad676077
AR
476 return 0;
477 }
db9aeca9 478 return dev_exception_add(devcgroup, &ex);
08ce5f16 479 case DEVCG_DENY:
ad676077
AR
480 /*
481 * If the default policy is to deny by default, try to remove
482 * an matching exception instead. And be silent about it: we
483 * don't want to break compatibility
484 */
5b7aa7d5 485 if (devcgroup->behavior == DEVCG_DEFAULT_DENY) {
db9aeca9 486 dev_exception_rm(devcgroup, &ex);
ad676077
AR
487 return 0;
488 }
db9aeca9 489 return dev_exception_add(devcgroup, &ex);
08ce5f16 490 default:
f92523e3 491 return -EINVAL;
08ce5f16 492 }
f92523e3
PM
493 return 0;
494}
08ce5f16 495
f92523e3
PM
496static int devcgroup_access_write(struct cgroup *cgrp, struct cftype *cft,
497 const char *buffer)
498{
499 int retval;
b4046f00
LZ
500
501 mutex_lock(&devcgroup_mutex);
f92523e3
PM
502 retval = devcgroup_update_access(cgroup_to_devcgroup(cgrp),
503 cft->private, buffer);
b4046f00 504 mutex_unlock(&devcgroup_mutex);
08ce5f16
SH
505 return retval;
506}
507
508static struct cftype dev_cgroup_files[] = {
509 {
510 .name = "allow",
f92523e3 511 .write_string = devcgroup_access_write,
08ce5f16
SH
512 .private = DEVCG_ALLOW,
513 },
514 {
515 .name = "deny",
f92523e3 516 .write_string = devcgroup_access_write,
08ce5f16
SH
517 .private = DEVCG_DENY,
518 },
29486df3
SH
519 {
520 .name = "list",
521 .read_seq_string = devcgroup_seq_read,
522 .private = DEVCG_LIST,
523 },
4baf6e33 524 { } /* terminate */
08ce5f16
SH
525};
526
08ce5f16
SH
527struct cgroup_subsys devices_subsys = {
528 .name = "devices",
529 .can_attach = devcgroup_can_attach,
530 .create = devcgroup_create,
c5b60b5e 531 .destroy = devcgroup_destroy,
08ce5f16 532 .subsys_id = devices_subsys_id,
4baf6e33 533 .base_cftypes = dev_cgroup_files,
8c7f6edb
TH
534
535 /*
536 * While devices cgroup has the rudimentary hierarchy support which
537 * checks the parent's restriction, it doesn't properly propagates
538 * config changes in ancestors to their descendents. A child
539 * should only be allowed to add more restrictions to the parent's
540 * configuration. Fix it and remove the following.
541 */
542 .broken_hierarchy = true,
08ce5f16
SH
543};
544
ad676077
AR
545/**
546 * __devcgroup_check_permission - checks if an inode operation is permitted
547 * @dev_cgroup: the dev cgroup to be tested against
548 * @type: device type
549 * @major: device major number
550 * @minor: device minor number
551 * @access: combination of ACC_WRITE, ACC_READ and ACC_MKNOD
552 *
553 * returns 0 on success, -EPERM case the operation is not permitted
554 */
8c9506d1 555static int __devcgroup_check_permission(short type, u32 major, u32 minor,
ad676077 556 short access)
08ce5f16 557{
8c9506d1 558 struct dev_cgroup *dev_cgroup;
db9aeca9 559 struct dev_exception_item ex;
ad676077 560 int rc;
36fd71d2 561
db9aeca9
AR
562 memset(&ex, 0, sizeof(ex));
563 ex.type = type;
564 ex.major = major;
565 ex.minor = minor;
566 ex.access = access;
36fd71d2 567
ad676077 568 rcu_read_lock();
8c9506d1 569 dev_cgroup = task_devcgroup(current);
db9aeca9 570 rc = may_access(dev_cgroup, &ex);
ad676077 571 rcu_read_unlock();
cd500819 572
ad676077
AR
573 if (!rc)
574 return -EPERM;
36fd71d2 575
ad676077
AR
576 return 0;
577}
08ce5f16 578
ad676077
AR
579int __devcgroup_inode_permission(struct inode *inode, int mask)
580{
ad676077
AR
581 short type, access = 0;
582
583 if (S_ISBLK(inode->i_mode))
584 type = DEV_BLOCK;
585 if (S_ISCHR(inode->i_mode))
586 type = DEV_CHAR;
587 if (mask & MAY_WRITE)
588 access |= ACC_WRITE;
589 if (mask & MAY_READ)
590 access |= ACC_READ;
591
8c9506d1
JS
592 return __devcgroup_check_permission(type, imajor(inode), iminor(inode),
593 access);
08ce5f16
SH
594}
595
596int devcgroup_inode_mknod(int mode, dev_t dev)
597{
ad676077 598 short type;
08ce5f16 599
0b82ac37
SH
600 if (!S_ISBLK(mode) && !S_ISCHR(mode))
601 return 0;
602
ad676077
AR
603 if (S_ISBLK(mode))
604 type = DEV_BLOCK;
605 else
606 type = DEV_CHAR;
36fd71d2 607
8c9506d1
JS
608 return __devcgroup_check_permission(type, MAJOR(dev), MINOR(dev),
609 ACC_MKNOD);
36fd71d2 610
08ce5f16 611}