[linux-2.6-block.git] / drivers / gpu / drm / i915 / intel_hdmi.c

/*
 * Copyright 2006 Dave Airlie <airlied@linux.ie>
 * Copyright © 2006-2009 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 *
 * Authors:
 *	Eric Anholt <eric@anholt.net>
 *	Jesse Barnes <jesse.barnes@intel.com>
 */

#include <linux/i2c.h>
#include <linux/delay.h>
#include "drmP.h"
#include "drm.h"
#include "drm_crtc.h"
#include "drm_edid.h"
#include "intel_drv.h"
#include "i915_drm.h"
#include "i915_drv.h"

struct intel_hdmi_priv {
	u32 sdvox_reg;
	u32 save_SDVOX;
	bool has_hdmi_sink;
};

static void intel_hdmi_mode_set(struct drm_encoder *encoder,
				struct drm_display_mode *mode,
				struct drm_display_mode *adjusted_mode)
{
	struct drm_device *dev = encoder->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct drm_crtc *crtc = encoder->crtc;
	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
	struct intel_output *intel_output = enc_to_intel_output(encoder);
	struct intel_hdmi_priv *hdmi_priv = intel_output->dev_priv;
	u32 sdvox;

	sdvox = SDVO_ENCODING_HDMI |
		SDVO_BORDER_ENABLE |
		SDVO_VSYNC_ACTIVE_HIGH |
		SDVO_HSYNC_ACTIVE_HIGH;

	if (hdmi_priv->has_hdmi_sink)
		sdvox |= SDVO_AUDIO_ENABLE;

	if (intel_crtc->pipe == 1)
		sdvox |= SDVO_PIPE_B_SELECT;

	I915_WRITE(hdmi_priv->sdvox_reg, sdvox);
	POSTING_READ(hdmi_priv->sdvox_reg);
}

static void intel_hdmi_dpms(struct drm_encoder *encoder, int mode)
{
	struct drm_device *dev = encoder->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_output *intel_output = enc_to_intel_output(encoder);
	struct intel_hdmi_priv *hdmi_priv = intel_output->dev_priv;
	u32 temp;

	if (mode != DRM_MODE_DPMS_ON) {
		temp = I915_READ(hdmi_priv->sdvox_reg);
		I915_WRITE(hdmi_priv->sdvox_reg, temp & ~SDVO_ENABLE);
	} else {
		temp = I915_READ(hdmi_priv->sdvox_reg);
		I915_WRITE(hdmi_priv->sdvox_reg, temp | SDVO_ENABLE);
	}
	POSTING_READ(hdmi_priv->sdvox_reg);
}

static void intel_hdmi_save(struct drm_connector *connector)
{
	struct drm_device *dev = connector->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_output *intel_output = to_intel_output(connector);
	struct intel_hdmi_priv *hdmi_priv = intel_output->dev_priv;

	hdmi_priv->save_SDVOX = I915_READ(hdmi_priv->sdvox_reg);
}

static void intel_hdmi_restore(struct drm_connector *connector)
{
	struct drm_device *dev = connector->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_output *intel_output = to_intel_output(connector);
	struct intel_hdmi_priv *hdmi_priv = intel_output->dev_priv;

	I915_WRITE(hdmi_priv->sdvox_reg, hdmi_priv->save_SDVOX);
	POSTING_READ(hdmi_priv->sdvox_reg);
}

static int intel_hdmi_mode_valid(struct drm_connector *connector,
				 struct drm_display_mode *mode)
{
	if (mode->clock > 165000)
		return MODE_CLOCK_HIGH;
	if (mode->clock < 20000)
		return MODE_CLOCK_HIGH;

	if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
		return MODE_NO_DBLESCAN;

	return MODE_OK;
}

static bool intel_hdmi_mode_fixup(struct drm_encoder *encoder,
				  struct drm_display_mode *mode,
				  struct drm_display_mode *adjusted_mode)
{
	return true;
}

static enum drm_connector_status
intel_hdmi_detect(struct drm_connector *connector)
{
	struct intel_output *intel_output = to_intel_output(connector);
	struct intel_hdmi_priv *hdmi_priv = intel_output->dev_priv;
	struct edid *edid = NULL;
	enum drm_connector_status status = connector_status_disconnected;

	hdmi_priv->has_hdmi_sink = false;
	edid = drm_get_edid(&intel_output->base,
			    intel_output->ddc_bus);

	if (edid) {
		if (edid->input & DRM_EDID_INPUT_DIGITAL) {
			status = connector_status_connected;
			hdmi_priv->has_hdmi_sink = drm_detect_hdmi_monitor(edid);
		}
		intel_output->base.display_info.raw_edid = NULL;
		kfree(edid);
	}

	return status;
}

static int intel_hdmi_get_modes(struct drm_connector *connector)
{
	struct intel_output *intel_output = to_intel_output(connector);

	/* We should parse the EDID data and find out if it's an HDMI sink so
	 * we can send audio to it.
	 */

	return intel_ddc_get_modes(intel_output);
}

static void intel_hdmi_destroy(struct drm_connector *connector)
{
	struct intel_output *intel_output = to_intel_output(connector);

	if (intel_output->i2c_bus)
		intel_i2c_destroy(intel_output->i2c_bus);
	drm_sysfs_connector_remove(connector);
	drm_connector_cleanup(connector);
	kfree(intel_output);
}

static const struct drm_encoder_helper_funcs intel_hdmi_helper_funcs = {
	.dpms = intel_hdmi_dpms,
	.mode_fixup = intel_hdmi_mode_fixup,
	.prepare = intel_encoder_prepare,
	.mode_set = intel_hdmi_mode_set,
	.commit = intel_encoder_commit,
};

static const struct drm_connector_funcs intel_hdmi_connector_funcs = {
	.dpms = drm_helper_connector_dpms,
	.save = intel_hdmi_save,
	.restore = intel_hdmi_restore,
	.detect = intel_hdmi_detect,
	.fill_modes = drm_helper_probe_single_connector_modes,
	.destroy = intel_hdmi_destroy,
};

static const struct drm_connector_helper_funcs intel_hdmi_connector_helper_funcs = {
	.get_modes = intel_hdmi_get_modes,
	.mode_valid = intel_hdmi_mode_valid,
	.best_encoder = intel_best_encoder,
};

static void intel_hdmi_enc_destroy(struct drm_encoder *encoder)
{
	drm_encoder_cleanup(encoder);
}

static const struct drm_encoder_funcs intel_hdmi_enc_funcs = {
	.destroy = intel_hdmi_enc_destroy,
};


void intel_hdmi_init(struct drm_device *dev, int sdvox_reg)
{
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct drm_connector *connector;
	struct intel_output *intel_output;
	struct intel_hdmi_priv *hdmi_priv;

	intel_output = kcalloc(sizeof(struct intel_output) +
			       sizeof(struct intel_hdmi_priv), 1, GFP_KERNEL);
	if (!intel_output)
		return;
	hdmi_priv = (struct intel_hdmi_priv *)(intel_output + 1);

	connector = &intel_output->base;
	drm_connector_init(dev, connector, &intel_hdmi_connector_funcs,
			   DRM_MODE_CONNECTOR_HDMIA);
	drm_connector_helper_add(connector, &intel_hdmi_connector_helper_funcs);

	intel_output->type = INTEL_OUTPUT_HDMI;

	connector->interlace_allowed = 0;
	connector->doublescan_allowed = 0;
	intel_output->crtc_mask = (1 << 0) | (1 << 1);

	/* Set up the DDC bus. */
	if (sdvox_reg == SDVOB) {
		intel_output->clone_mask = (1 << INTEL_HDMIB_CLONE_BIT);
		intel_output->ddc_bus = intel_i2c_create(dev, GPIOE, "HDMIB");
	} else if (sdvox_reg == SDVOC) {
		intel_output->clone_mask = (1 << INTEL_HDMIC_CLONE_BIT);
		intel_output->ddc_bus = intel_i2c_create(dev, GPIOD, "HDMIC");
	} else if (sdvox_reg == HDMIB) {
		intel_output->clone_mask = (1 << INTEL_HDMID_CLONE_BIT);
		intel_output->ddc_bus = intel_i2c_create(dev, PCH_GPIOE,
								"HDMIB");
	} else if (sdvox_reg == HDMIC) {
		intel_output->clone_mask = (1 << INTEL_HDMIE_CLONE_BIT);
		intel_output->ddc_bus = intel_i2c_create(dev, PCH_GPIOD,
								"HDMIC");
	} else if (sdvox_reg == HDMID) {
		intel_output->clone_mask = (1 << INTEL_HDMIF_CLONE_BIT);
		intel_output->ddc_bus = intel_i2c_create(dev, PCH_GPIOF,
								"HDMID");
	}
	if (!intel_output->ddc_bus)
		goto err_connector;

	hdmi_priv->sdvox_reg = sdvox_reg;
	intel_output->dev_priv = hdmi_priv;

	drm_encoder_init(dev, &intel_output->enc, &intel_hdmi_enc_funcs,
			 DRM_MODE_ENCODER_TMDS);
	drm_encoder_helper_add(&intel_output->enc, &intel_hdmi_helper_funcs);

	drm_mode_connector_attach_encoder(&intel_output->base,
					  &intel_output->enc);
	drm_sysfs_connector_add(connector);

	/* For G4X desktop chip, PEG_BAND_GAP_DATA 3:0 must first be written
	 * 0xd.  Failure to do so will result in spurious interrupts being
	 * generated on the port when a cable is not attached.
	 */
	if (IS_G4X(dev) && !IS_GM45(dev)) {
		u32 temp = I915_READ(PEG_BAND_GAP_DATA);
		I915_WRITE(PEG_BAND_GAP_DATA, (temp & ~0xf) | 0xd);
	}

	return;

err_connector:
	drm_connector_cleanup(connector);
	kfree(intel_output);

	return;
}
Commit	Line	Data
7d57382e EA	1	/*
	2	* Copyright 2006 Dave Airlie <airlied@linux.ie>
	3	* Copyright © 2006-2009 Intel Corporation
	4	*
	5	* Permission is hereby granted, free of charge, to any person obtaining a
	6	* copy of this software and associated documentation files (the "Software"),
	7	* to deal in the Software without restriction, including without limitation
	8	* the rights to use, copy, modify, merge, publish, distribute, sublicense,
	9	* and/or sell copies of the Software, and to permit persons to whom the
	10	* Software is furnished to do so, subject to the following conditions:
	11	*
	12	* The above copyright notice and this permission notice (including the next
	13	* paragraph) shall be included in all copies or substantial portions of the
	14	* Software.
	15	*
	16	* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
	17	* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
	18	* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
	19	* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
	20	* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
	21	* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
	22	* DEALINGS IN THE SOFTWARE.
	23	*
	24	* Authors:
	25	* Eric Anholt <eric@anholt.net>
	26	* Jesse Barnes <jesse.barnes@intel.com>
	27	*/
	28
	29	#include <linux/i2c.h>
	30	#include <linux/delay.h>
	31	#include "drmP.h"
	32	#include "drm.h"
	33	#include "drm_crtc.h"
aa93d632	34	#include "drm_edid.h"
7d57382e EA	35	#include "intel_drv.h"
	36	#include "i915_drm.h"
	37	#include "i915_drv.h"
	38
	39	struct intel_hdmi_priv {
	40	u32 sdvox_reg;
	41	u32 save_SDVOX;
9dff6af8	42	bool has_hdmi_sink;
7d57382e EA	43	};
	44
	45	static void intel_hdmi_mode_set(struct drm_encoder *encoder,
	46	struct drm_display_mode *mode,
	47	struct drm_display_mode *adjusted_mode)
	48	{
	49	struct drm_device *dev = encoder->dev;
	50	struct drm_i915_private *dev_priv = dev->dev_private;
	51	struct drm_crtc *crtc = encoder->crtc;
	52	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
	53	struct intel_output *intel_output = enc_to_intel_output(encoder);
	54	struct intel_hdmi_priv *hdmi_priv = intel_output->dev_priv;
	55	u32 sdvox;
	56
	57	sdvox = SDVO_ENCODING_HDMI \|
	58	SDVO_BORDER_ENABLE \|
	59	SDVO_VSYNC_ACTIVE_HIGH \|
56d21b07	60	SDVO_HSYNC_ACTIVE_HIGH;
7d57382e EA	61
	62	if (hdmi_priv->has_hdmi_sink)
	63	sdvox \|= SDVO_AUDIO_ENABLE;
	64
	65	if (intel_crtc->pipe == 1)
	66	sdvox \|= SDVO_PIPE_B_SELECT;
	67
	68	I915_WRITE(hdmi_priv->sdvox_reg, sdvox);
	69	POSTING_READ(hdmi_priv->sdvox_reg);
	70	}
	71
	72	static void intel_hdmi_dpms(struct drm_encoder *encoder, int mode)
	73	{
	74	struct drm_device *dev = encoder->dev;
	75	struct drm_i915_private *dev_priv = dev->dev_private;
	76	struct intel_output *intel_output = enc_to_intel_output(encoder);
	77	struct intel_hdmi_priv *hdmi_priv = intel_output->dev_priv;
	78	u32 temp;
	79
	80	if (mode != DRM_MODE_DPMS_ON) {
	81	temp = I915_READ(hdmi_priv->sdvox_reg);
	82	I915_WRITE(hdmi_priv->sdvox_reg, temp & ~SDVO_ENABLE);
	83	} else {
	84	temp = I915_READ(hdmi_priv->sdvox_reg);
	85	I915_WRITE(hdmi_priv->sdvox_reg, temp \| SDVO_ENABLE);
	86	}
	87	POSTING_READ(hdmi_priv->sdvox_reg);
	88	}
	89
	90	static void intel_hdmi_save(struct drm_connector *connector)
	91	{
	92	struct drm_device *dev = connector->dev;
	93	struct drm_i915_private *dev_priv = dev->dev_private;
	94	struct intel_output *intel_output = to_intel_output(connector);
	95	struct intel_hdmi_priv *hdmi_priv = intel_output->dev_priv;
	96
	97	hdmi_priv->save_SDVOX = I915_READ(hdmi_priv->sdvox_reg);
	98	}
	99
	100	static void intel_hdmi_restore(struct drm_connector *connector)
	101	{
	102	struct drm_device *dev = connector->dev;
	103	struct drm_i915_private *dev_priv = dev->dev_private;
	104	struct intel_output *intel_output = to_intel_output(connector);
	105	struct intel_hdmi_priv *hdmi_priv = intel_output->dev_priv;
	106
	107	I915_WRITE(hdmi_priv->sdvox_reg, hdmi_priv->save_SDVOX);
	108	POSTING_READ(hdmi_priv->sdvox_reg);
	109	}
	110
	111	static int intel_hdmi_mode_valid(struct drm_connector *connector,
	112	struct drm_display_mode *mode)
	113	{
	114	if (mode->clock > 165000)
	115	return MODE_CLOCK_HIGH;
	116	if (mode->clock < 20000)
	117	return MODE_CLOCK_HIGH;
	118
	119	if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
	120	return MODE_NO_DBLESCAN;
	121
	122	return MODE_OK;
	123	}
	124
125	static bool intel_hdmi_mode_fixup(struct drm_encoder *encoder,
126	struct drm_display_mode *mode,
127	struct drm_display_mode *adjusted_mode)
128	{
129	return true;
130	}
131
aa93d632	132	static enum drm_connector_status
2ded9e27	133	intel_hdmi_detect(struct drm_connector *connector)
9dff6af8 ML	134	{
	135	struct intel_output *intel_output = to_intel_output(connector);
	136	struct intel_hdmi_priv *hdmi_priv = intel_output->dev_priv;
	137	struct edid *edid = NULL;
aa93d632	138	enum drm_connector_status status = connector_status_disconnected;
9dff6af8	139
2ded9e27	140	hdmi_priv->has_hdmi_sink = false;
9dff6af8	141	edid = drm_get_edid(&intel_output->base,
f9c10a9b	142	intel_output->ddc_bus);
2ded9e27	143
aa93d632	144	if (edid) {
be9f1c4f	145	if (edid->input & DRM_EDID_INPUT_DIGITAL) {
aa93d632 KP	146	status = connector_status_connected;
	147	hdmi_priv->has_hdmi_sink = drm_detect_hdmi_monitor(edid);
	148	}
9dff6af8	149	intel_output->base.display_info.raw_edid = NULL;
aa93d632	150	kfree(edid);
9dff6af8	151	}
30ad48b7	152
2ded9e27	153	return status;
7d57382e EA	154	}
	155
	156	static int intel_hdmi_get_modes(struct drm_connector *connector)
	157	{
	158	struct intel_output *intel_output = to_intel_output(connector);
	159
	160	/* We should parse the EDID data and find out if it's an HDMI sink so
	161	* we can send audio to it.
	162	*/
	163
	164	return intel_ddc_get_modes(intel_output);
	165	}
	166
	167	static void intel_hdmi_destroy(struct drm_connector *connector)
	168	{
	169	struct intel_output *intel_output = to_intel_output(connector);
	170
	171	if (intel_output->i2c_bus)
	172	intel_i2c_destroy(intel_output->i2c_bus);
	173	drm_sysfs_connector_remove(connector);
	174	drm_connector_cleanup(connector);
	175	kfree(intel_output);
	176	}
	177
	178	static const struct drm_encoder_helper_funcs intel_hdmi_helper_funcs = {
	179	.dpms = intel_hdmi_dpms,
	180	.mode_fixup = intel_hdmi_mode_fixup,
	181	.prepare = intel_encoder_prepare,
	182	.mode_set = intel_hdmi_mode_set,
	183	.commit = intel_encoder_commit,
	184	};
	185
	186	static const struct drm_connector_funcs intel_hdmi_connector_funcs = {
c9fb15f6	187	.dpms = drm_helper_connector_dpms,
7d57382e EA	188	.save = intel_hdmi_save,
	189	.restore = intel_hdmi_restore,
	190	.detect = intel_hdmi_detect,
	191	.fill_modes = drm_helper_probe_single_connector_modes,
	192	.destroy = intel_hdmi_destroy,
	193	};
	194
	195	static const struct drm_connector_helper_funcs intel_hdmi_connector_helper_funcs = {
	196	.get_modes = intel_hdmi_get_modes,
	197	.mode_valid = intel_hdmi_mode_valid,
	198	.best_encoder = intel_best_encoder,
	199	};
	200
	201	static void intel_hdmi_enc_destroy(struct drm_encoder *encoder)
	202	{
	203	drm_encoder_cleanup(encoder);
	204	}
	205
	206	static const struct drm_encoder_funcs intel_hdmi_enc_funcs = {
	207	.destroy = intel_hdmi_enc_destroy,
	208	};
	209
	210
	211	void intel_hdmi_init(struct drm_device *dev, int sdvox_reg)
	212	{
	213	struct drm_i915_private *dev_priv = dev->dev_private;
	214	struct drm_connector *connector;
	215	struct intel_output *intel_output;
	216	struct intel_hdmi_priv *hdmi_priv;
	217
	218	intel_output = kcalloc(sizeof(struct intel_output) +
	219	sizeof(struct intel_hdmi_priv), 1, GFP_KERNEL);
	220	if (!intel_output)
	221	return;
	222	hdmi_priv = (struct intel_hdmi_priv *)(intel_output + 1);
	223
	224	connector = &intel_output->base;
	225	drm_connector_init(dev, connector, &intel_hdmi_connector_funcs,
8d91104a	226	DRM_MODE_CONNECTOR_HDMIA);
7d57382e EA	227	drm_connector_helper_add(connector, &intel_hdmi_connector_helper_funcs);
	228
	229	intel_output->type = INTEL_OUTPUT_HDMI;
	230
	231	connector->interlace_allowed = 0;
	232	connector->doublescan_allowed = 0;
f8aed700	233	intel_output->crtc_mask = (1 << 0) \| (1 << 1);
7d57382e EA	234
7d57382e EA	235	/* Set up the DDC bus. */
f8aed700 ML	236	if (sdvox_reg == SDVOB) {
f8aed700 ML	237	intel_output->clone_mask = (1 << INTEL_HDMIB_CLONE_BIT);
7d57382e	238	intel_output->ddc_bus = intel_i2c_create(dev, GPIOE, "HDMIB");
f8aed700 ML	239	} else if (sdvox_reg == SDVOC) {
f8aed700 ML	240	intel_output->clone_mask = (1 << INTEL_HDMIC_CLONE_BIT);
7d57382e	241	intel_output->ddc_bus = intel_i2c_create(dev, GPIOD, "HDMIC");
f8aed700 ML	242	} else if (sdvox_reg == HDMIB) {
f8aed700 ML	243	intel_output->clone_mask = (1 << INTEL_HDMID_CLONE_BIT);
30ad48b7 ZW	244	intel_output->ddc_bus = intel_i2c_create(dev, PCH_GPIOE,
30ad48b7 ZW	245	"HDMIB");
f8aed700 ML	246	} else if (sdvox_reg == HDMIC) {
f8aed700 ML	247	intel_output->clone_mask = (1 << INTEL_HDMIE_CLONE_BIT);
30ad48b7 ZW	248	intel_output->ddc_bus = intel_i2c_create(dev, PCH_GPIOD,
30ad48b7 ZW	249	"HDMIC");
f8aed700 ML	250	} else if (sdvox_reg == HDMID) {
f8aed700 ML	251	intel_output->clone_mask = (1 << INTEL_HDMIF_CLONE_BIT);
30ad48b7 ZW	252	intel_output->ddc_bus = intel_i2c_create(dev, PCH_GPIOF,
30ad48b7 ZW	253	"HDMID");
f8aed700	254	}
7d57382e EA	255	if (!intel_output->ddc_bus)
	256	goto err_connector;
	257
	258	hdmi_priv->sdvox_reg = sdvox_reg;
	259	intel_output->dev_priv = hdmi_priv;
	260
	261	drm_encoder_init(dev, &intel_output->enc, &intel_hdmi_enc_funcs,
	262	DRM_MODE_ENCODER_TMDS);
	263	drm_encoder_helper_add(&intel_output->enc, &intel_hdmi_helper_funcs);
	264
	265	drm_mode_connector_attach_encoder(&intel_output->base,
	266	&intel_output->enc);
	267	drm_sysfs_connector_add(connector);
	268
	269	/* For G4X desktop chip, PEG_BAND_GAP_DATA 3:0 must first be written
	270	* 0xd. Failure to do so will result in spurious interrupts being
	271	* generated on the port when a cable is not attached.
	272	*/
	273	if (IS_G4X(dev) && !IS_GM45(dev)) {
	274	u32 temp = I915_READ(PEG_BAND_GAP_DATA);
	275	I915_WRITE(PEG_BAND_GAP_DATA, (temp & ~0xf) \| 0xd);
	276	}
	277
	278	return;
	279
	280	err_connector:
	281	drm_connector_cleanup(connector);
	282	kfree(intel_output);
	283
	284	return;
	285	}